ports/stm32: Updated STM32L452XX Multi OTG handling #15796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code size report: |
0009998 to
57432ca
Compare
|
On a tangentially related note, if / when this is completed it should simplify USB compatibility and remove the need for per-chip-type handling of all these: Draft: stm32/usb: Add support for using TinyUSB stack by default. #15592 |
|
I couldn't find it after a quick look, but I do have a Blues Wireless Swan board somewhere. The micro it's built on is the STM32L4R5ZIY6 - if that's useful to test this PR on then let me know and I'll hunt down the board... |
dpgeorge
approved these changes
Sep 10, 2024
Added custom Multi OTG handling for STM32L452xx, based on STM32L432xx handling. Fixes issue micropython#15795. Signed-off-by: Adrian Higgins <adrian@higstar.com>
57432ca to
39ddfed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added custom Multi OTG handling for STM32L452XX
based on STM32L432XX handling.
#15795
Summary
To enable USB when using an L4 which is not based on the L432, Multi OTG handling seems to fall through the cracks, and results in the build not completing.
Testing
I do not yet have HW, so have not been able to test on a L452 target.
Trade-offs and Alternatives
Ideally the multi OTG handling would not involve piecemeal handling for specific targets, which then needs springling around various files.