Skip to content

github/workflows: Update Ubuntu images for code size CI tasks. #15884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2024
Merged

github/workflows: Update Ubuntu images for code size CI tasks. #15884

merged 1 commit into from
Sep 23, 2024

Conversation

agatti
Copy link
Contributor

@agatti agatti commented Sep 20, 2024

Summary

The code size calculation CI tasks were still on Ubuntu 20.04, which is a problem for #15843 as Ubuntu 20.04 does not provide the necessary packages for building RISC-V code.

Testing

The code size CI tasks completed successfully in my branch: https://github.com/agatti/micropython/actions/runs/10957423395.

@codecov Codecov
Copy link

codecov bot commented Sep 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.57%. Comparing base (f1b88e0) to head (8a9042a).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #15884   +/-   ##
=======================================
  Coverage   98.57%   98.57%           
=======================================
  Files         164      164           
  Lines       21341    21341           
=======================================
  Hits        21036    21036           
  Misses        305      305

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS

@agatti agatti mentioned this pull request Sep 20, 2024
Merged
@agatti @dpgeorge
github/workflows: Update Ubuntu images for code size CI tasks.
8a9042a 
This updates the Ubuntu OS image the code size CI tasks run on, from
20.04-LTS to 22.04-LTS.  This is needed because 20.04 didn't have
packages that are needed to build RISC-V 32 code.

Signed-off-by: Alessandro Gatti <a.gatti@frob.it>
@dpgeorge dpgeorge force-pushed the codesize-ci-image-update branch from 55a0a7b to 8a9042a Compare September 23, 2024 02:42
@dpgeorge dpgeorge merged commit 8a9042a into micropython:master Sep 23, 2024
65 checks passed
@agatti agatti deleted the codesize-ci-image-update branch September 23, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgeorge dpgeorge dpgeorge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agatti @dpgeorge