esp8266: fix bugs in esp8266/modnetwork.c when connecting to ap #3083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since the station_config struct is initialised to all zeros at the beginning of the function there's no need to store the empty string in the case that the password is not given. You can just put the memcpy for the password into the |
|
OK, I see. Changed it that way. Tested it successfully by connecting to an unprotected and a WPA2 encrypted network. |
|
Thanks, merged in 4b23580 |
|
@puuu : Thanks for being around and fixing it! |
kamtom480
pushed a commit
to kamtom480/micropython
that referenced
this pull request
Jul 2, 2020
Add busio support for the ESP32-S2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patches should fix the bugs discussed in #3061 .