mimxrt/machine_pin: Updated DRIVE_# constants. #8389
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated DRIVE_# constants representing pin drive strength. Signed-off-by: Philipp Ebensberger
|
@dpgeorge based on our discussion from #8313. On a side note, it would be really great if you would find the time to also take a look at @robert-hh PR #7494 allowing us to bring some documentation for the mimxrt port to mainline. |
dpgeorge
reviewed
Mar 8, 2022
| { MP_ROM_QSTR(MP_QSTR_POWER_4), MP_ROM_INT(PIN_DRIVE_POWER_4) }, // R0/5 | ||
| { MP_ROM_QSTR(MP_QSTR_POWER_5), MP_ROM_INT(PIN_DRIVE_POWER_5) }, // R0/6 | ||
| { MP_ROM_QSTR(MP_QSTR_POWER_6), MP_ROM_INT(PIN_DRIVE_POWER_6) }, // R0/7 | ||
| { MP_ROM_QSTR(MP_QSTR_DRIVE_OFF), MP_ROM_INT(PIN_DRIVE_OFF) }, |
There was a problem hiding this comment.
Is this level really off, ie it does not drive the GPIO at all? Or is it just a very weak drive?
There was a problem hiding this comment.
According to the documentation it turns the output driver off.
There was a problem hiding this comment.
Tested: It switches the driver off. With a 0.9 MOhm load and the value set to 1, the output voltage drops to 0.01V. When drive=Pin.DRIVE_OFF is set. With drive=Pin.DRIVE_0, the output voltage reads 3.28 V.
|
Rebased and merged in 62cb206 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated DRIVE_# constants representing pin drive strength.
Signed-off-by: Philipp Ebensberger