Skip to content

Implement functools.partial function. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wrobell opened this issue May 8, 2014 · 2 comments
Closed

Implement functools.partial function. #1

wrobell opened this issue May 8, 2014 · 2 comments

Comments

@wrobell
Copy link

wrobell commented May 8, 2014

Implement functools.partial function.

Is there any C/asm optimization possible or shall we stick to pure Python version for next few months?

@pfalcon
Copy link
Contributor

pfalcon commented May 8, 2014

There's exactly no universal/scalable way to do such optimization, so I suggest implementing as much stuff as possible in Python, then analyze performance, and if something is really at bottleneck, optimize it.

@pfalcon
Copy link
Contributor

pfalcon commented May 19, 2014

Done.

@pfalcon pfalcon closed this as completed May 19, 2014
pfalcon added a commit that referenced this issue Feb 1, 2018
During development, following questions were posed, and subsequently,
answered:

Q #1: Should this be in uasyncio package at all? Upstream doesn't have
this. Pro: will be easier for people do discover (see e.g.
#148)

A: uasyncio diverges more and more from asyncio, so if something is
convinient for uasyncio, there's no need to look back at asyncio.

Q #2: This provides implements 2 ways to create a WS connections:
1) using start_ws_server(); 2) using wrapping existing StreamReader
and StreamWriter. History: initial prototype of course used 2). But
the idea was "it should be like the official start_server()!!1". But
then I though how to integrate it e.g. with Picoweb, and became clear
that 2) is the most flixble way. So, 1) is intended to be removed.

A: 1) was removed and is not part of the merged version of the patch.

Q #3: Uses native websocket module for read path, but has own
write path due to micropython/micropython#3396

A: So far, so good.

Q #4: Requires #227
due to micropython/micropython#3394 .

A: The prerequisite was merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants