Skip to content

Add check for undefined declarations #14343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
2 commits merged into from
Feb 28, 2017
Merged

Add check for undefined declarations #14343

2 commits merged into from
Feb 28, 2017

Conversation

ghost
Copy link

@ghost ghost commented Feb 27, 2017

Fixes #14299

mhegazy
mhegazy reviewed Feb 27, 2017
View reviewed changes
src/services/goToDefinition.ts Outdated
const declarations: Declaration[] = [];
let definition: Declaration | undefined;

for (const d of signatureDeclarations) {
if (signatureDeclarations) for (const d of signatureDeclarations) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split on two lines.

@ghost ghost force-pushed the undefined_declarations branch from 9ec86e6 to 55b9f04 Compare February 28, 2017 14:10
@ghost ghost force-pushed the undefined_declarations branch from 55b9f04 to 7afee8c Compare February 28, 2017 15:55
@ghost ghost merged commit fc9bcc1 into master Feb 28, 2017
@ghost ghost deleted the undefined_declarations branch February 28, 2017 16:44
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhegazy @msftclas