Fix return types of NodeBuilder methods #21619
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with the NodeBuilder methods that are exposed from TypeChecker, I noticed that they might return
undefined
, but the return type doesn't include undefined.This changes all return types to an undefined union.
I don't know if this is the right thing to do. Shouldn't these methods throw an error if the input does not match the NodeBuilderFlags? With the current implementation you cannot tell what's wrong, you just get
undefined
.In addition
signatureToSignatureDeclaration
can return a node withtypeArguments
if you passNodeBuilderFlags.WriteTypeArgumentsOfSignature
. This method now returns an IntersectionType because there's not way to extendSignatureDeclaration
in another interface.This could be changed to return an interface that extends
SignatureDeclarationBase
instead.