In JSDoc, resolve import types as values too #26066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is something that we probably should have been doing for some time. Fixes #26049
weswigham
approved these changes
Jul 31, 2018
There was a problem hiding this comment.
While this jibes with what we had done in the past for other jsdocs, I think we should probably be binding with the desired meaning in the first place (esp. since in this case there's no ambiguity about if a type is needed like with a function declaration - the @enum tag ensures there will be both a type and a value!). That's probably a larger change, though. 🤷♂️
|
Yes, I agree in general. It's nice to have this as a fallback, though. And for the specific case of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something that we probably should have been doing for some time.
Fixes #26049