Skip to content

Emits safe value for import. #4355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2015
Merged

Emits safe value for import. #4355

merged 2 commits into from
Aug 19, 2015

Conversation

DavidSouther
Copy link
Contributor

Fixes #4354

@msftclas
Copy link

Hi @DavidSouther, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@DavidSouther
Copy link
Contributor Author

Working on adding some tests now.

@mhegazy
Copy link
Contributor

mhegazy commented Aug 19, 2015

Thanks!

mhegazy added a commit that referenced this pull request Aug 19, 2015
Emits safe value for import.
@mhegazy mhegazy merged commit 478cc32 into microsoft:master Aug 19, 2015
@DavidSouther
Copy link
Contributor Author

No, thank you! What's the lag time on bugfix released to npm?

@DanielRosenwasser
Copy link
Member

@DavidSouther you can get our nightly with npm install -g typescript@next. Should be up by ~midnight Pacific time.

@DanielRosenwasser
Copy link
Member

@mhegazy this doesn't ensure uniqueness, and in fact, the old function didn't either.

@mhegazy
Copy link
Contributor

mhegazy commented Aug 19, 2015

@DanielRosenwasser, this is just the basename, we then call makeUniqueName with the basename as a seed. this makes sure it is unique.

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants