Skip to content

chore: use a singleton "builtins" instead of passing it around #35493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 10, 2025
Merged

chore: use a singleton "builtins" instead of passing it around #35493

merged 3 commits into from
Apr 10, 2025

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Apr 4, 2025

Also enable builtins linter for utils/isomorphic.

@dgozman dgozman requested a review from yury-s April 4, 2025 15:06
yury-s
yury-s reviewed Apr 4, 2025
View reviewed changes
Copy link
Member

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good but it seems like we lack an agreement on babel vs explicit object approach.

@dgozman dgozman force-pushed the chore-builtins-simpler branch from c043190 to 88cf24a Compare April 7, 2025 09:57
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@dgozman dgozman requested a review from yury-s April 8, 2025 15:01
@dgozman dgozman force-pushed the chore-builtins-simpler branch from 88cf24a to f78f319 Compare April 9, 2025 10:08
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@dgozman dgozman force-pushed the chore-builtins-simpler branch from f78f319 to 60c31f8 Compare April 9, 2025 13:59
@dgozman dgozman changed the title chore: use a singleton "builtins" instances instead of passing it around chore: use a singleton "builtins" instead of passing it around Apr 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

Test results for "tests 1"

1 failed
❌ [legacy-trace] › run-tests.spec.ts:1153:5 › should produce output twice @vscode-extension

7 flaky ⚠️ [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node20
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:23:7 › cli codegen › should click @ubuntu-22.04-chromium-tip-of-tree
⚠️ [chromium-library] › library/popup.spec.ts:264:3 › should not throw when click closes popup @ubuntu-22.04-chromium-tip-of-tree
⚠️ [webkit-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/elementhandle-screenshot.spec.ts:36:5 › element screenshot › should work when main world busts JSON.stringify @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39108 passed, 807 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit c9a1ad4 into microsoft:main Apr 10, 2025
28 of 29 checks passed
This was referenced Apr 10, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yury-s yury-s yury-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgozman @yury-s