fix(assertions): allow tuple as valid input type for expected text values (#2723)

mxschmitt · web-flow · commit 4ecf61e18bec · 2025-01-27T09:39:55.000+01:00
diff --git a/playwright/_impl/_assertions.py b/playwright/_impl/_assertions.py
@@ -874,7 +874,7 @@ def to_expected_text_values(
     ignoreCase: Optional[bool] = None,
 ) -> Sequence[ExpectedTextValue]:
     out: List[ExpectedTextValue] = []
-    assert isinstance(items, list)
+    assert isinstance(items, (list, tuple))
     for item in items:
         if isinstance(item, str):
             o = ExpectedTextValue(
diff --git a/tests/async/test_assertions.py b/tests/async/test_assertions.py
@@ -274,6 +274,10 @@ async def test_assertions_locator_to_have_text(page: Page, server: Server) -> No
     await expect(page.locator("div")).to_have_text(
         ["Text  1", re.compile(r"Text   \d+a")]
     )
+    # Should work with a tuple
+    await expect(page.locator("div")).to_have_text(
+        ("Text  1", re.compile(r"Text   \d+a"))
+    )
 
 
 @pytest.mark.parametrize(

Original file line number	Diff line number	Diff line change
`@@ -274,6 +274,10 @@ async def test_assertions_locator_to_have_text(page: Page, server: Server) -> No`
`274`	`274`	`await expect(page.locator("div")).to_have_text(`
`275`	`275`	`["Text 1", re.compile(r"Text \d+a")]`
`276`	`276`	`)`
	`277`	`+ # Should work with a tuple`
	`278`	`+ await expect(page.locator("div")).to_have_text(`
	`279`	`+ ("Text 1", re.compile(r"Text \d+a"))`
	`280`	`+ )`
`277`	`281`
`278`	`282`
`279`	`283`	`@pytest.mark.parametrize(`