test: unflake tests (#2768)

mxschmitt · web-flow · commit 55725d50e370 · 2025-03-06T14:21:14.000+01:00
diff --git a/tests/async/test_defaultbrowsercontext.py b/tests/async/test_defaultbrowsercontext.py
@@ -21,14 +21,22 @@
     Awaitable,
     Callable,
     Dict,
+    List,
     Literal,
     Optional,
     Tuple,
 )
 
 import pytest
 
-from playwright.async_api import BrowserContext, BrowserType, Error, Page, expect
+from playwright.async_api import (
+    BrowserContext,
+    BrowserType,
+    Cookie,
+    Error,
+    Page,
+    expect,
+)
 from tests.server import Server
 from tests.utils import must
 
@@ -116,6 +124,12 @@ async def test_context_add_cookies_should_work(
     ]
 
 
+def _filter_cookies(cookies: List[Cookie]) -> List[Cookie]:
+    return list(
+        filter(lambda cookie: cookie["domain"] != "copilot.microsoft.com", cookies)
+    )
+
+
 async def test_context_clear_cookies_should_work(
     server: Server,
     launch_persistent: "Callable[..., asyncio.Future[Tuple[Page, BrowserContext]]]",
@@ -131,7 +145,7 @@ async def test_context_clear_cookies_should_work(
     assert await page.evaluate("document.cookie") == "cookie1=1; cookie2=2"
     await page.context.clear_cookies()
     await page.reload()
-    assert await page.context.cookies([]) == []
+    assert _filter_cookies(await page.context.cookies([])) == []
     assert await page.evaluate("document.cookie") == ""
 
 
diff --git a/tests/async/test_selector_generator.py b/tests/async/test_selector_generator.py
@@ -40,7 +40,7 @@ async def test_should_use_data_test_id_in_strict_errors(
         """
         )
         with pytest.raises(Error) as exc_info:
-            await page.locator(".foo").hover(timeout=200)
+            await page.locator(".foo").hover()
         assert "strict mode violation" in exc_info.value.message
         assert '<div class="foo bar:0' in exc_info.value.message
         assert '<div class="foo bar:1' in exc_info.value.message

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ async def test_should_use_data_test_id_in_strict_errors(`
`40`	`40`	`"""`
`41`	`41`	`)`
`42`	`42`	`with pytest.raises(Error) as exc_info:`
`43`		`- await page.locator(".foo").hover(timeout=200)`
	`43`	`+ await page.locator(".foo").hover()`
`44`	`44`	`assert "strict mode violation" in exc_info.value.message`
`45`	`45`	`assert '<div class="foo bar:0' in exc_info.value.message`
`46`	`46`	`assert '<div class="foo bar:1' in exc_info.value.message`