chore: add missing methods and use a set for it

mxschmitt · mxschmitt · commit a63f0ef7c9d0 · 2020-09-03T15:21:14.000+02:00
diff --git a/playwright/async_api.py b/playwright/async_api.py
@@ -810,6 +810,15 @@ class ElementHandle(JSHandle):
     def __init__(self, obj: ElementHandleImpl):
         super().__init__(obj)
 
+    def toString(self) -> str:
+        """ElementHandle.toString
+
+        Returns
+        -------
+        str
+        """
+        return mapping.from_maybe_impl(self._impl_obj.toString())
+
     def asElement(self) -> typing.Union["ElementHandle", NoneType]:
         """ElementHandle.asElement
 
diff --git a/playwright/element_handle.py b/playwright/element_handle.py
@@ -51,6 +51,9 @@ def __init__(
     ) -> None:
         super().__init__(parent, type, guid, initializer)
 
+    def toString(self) -> str:
+        return self._preview
+
     def asElement(self) -> Optional["ElementHandle"]:
         return self
 
diff --git a/playwright/sync_api.py b/playwright/sync_api.py
@@ -830,6 +830,15 @@ class ElementHandle(JSHandle):
     def __init__(self, obj: ElementHandleImpl):
         super().__init__(obj)
 
+    def toString(self) -> str:
+        """ElementHandle.toString
+
+        Returns
+        -------
+        str
+        """
+        return mapping.from_maybe_impl(self._impl_obj.toString())
+
     def asElement(self) -> typing.Union["ElementHandle", NoneType]:
         """ElementHandle.asElement
 
diff --git a/scripts/documentation_provider.py b/scripts/documentation_provider.py
@@ -371,6 +371,7 @@ def rewrite_param_name(self, fqname: str, method_name: str, name: str) -> str:
         return name
 
     def print_remainder(self) -> None:
+        remainders = set()
         for [class_name, value] in self.api.items():
             class_name = re.sub(r"Chromium(.*)", r"\1", class_name)
             class_name = re.sub(r"WebKit(.*)", r"\1", class_name)
@@ -380,7 +381,9 @@ def print_remainder(self) -> None:
                     continue
                 entry = f"{class_name}.{method_name}"
                 if entry not in self.printed_entries:
-                    print(f"Method not implemented: {entry}", file=stderr)
+                    remainders.add(f"Method not implemented: {entry}")
+        for remainder in remainders:
+            print(remainder, file=stderr)
 
 
 if __name__ == "__main__":
diff --git a/scripts/generate_async_api.py b/scripts/generate_async_api.py
@@ -1,3 +1,4 @@
+#!/usr/bin/env python
 # Copyright (c) Microsoft Corporation.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
diff --git a/scripts/generate_sync_api.py b/scripts/generate_sync_api.py
@@ -1,3 +1,4 @@
+#!/usr/bin/env python
 # Copyright (c) Microsoft Corporation.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+#!/usr/bin/env python`
`1`	`2`	`# Copyright (c) Microsoft Corporation.`
`2`	`3`	`#`
`3`	`4`	`# Licensed under the Apache License, Version 2.0 (the "License");`