fix channel tests

mxschmitt · mxschmitt · commit ac6847bbd25c · 2021-07-28T08:53:28.000+02:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -143,7 +143,7 @@ jobs:
         python setup.py bdist_wheel
         python -m playwright install-deps
     - name: Install ffmpeg
-      run: python -m playwright install ffmpeg
+      run: python -m playwright install ${{ matrix.browser-channel }}
     - name: Common Tests
       run: pytest tests/common --browser=chromium --browser-channel=${{ matrix.browser-channel }} --timeout 90
     - name: Test Sync API
diff --git a/tests/sync/test_accessibility.py b/tests/sync/test_accessibility.py
@@ -215,29 +215,17 @@ def test_accessibility_filtering_children_of_leaf_nodes_rich_text_editable_field
             "children": [{"role": "text", "name": "my fake image"}],
         }
     else:
-        if browser_channel:
-            golden = {
-                "role": "textbox",
-                "name": "",
-                "value": "Edit this image: ",
-                "children": [
-                    {"role": "text", "name": "Edit this image:"},
-                    {"role": "img", "name": "my fake image"},
-                ],
-                "value": "Edit this image: ",
-            }
-        else:
-            golden = {
-                "role": "textbox",
-                "name": "",
-                "multiline": True,
-                "value": "Edit this image: ",
-                "children": [
-                    {"role": "text", "name": "Edit this image:"},
-                    {"role": "img", "name": "my fake image"},
-                ],
-                "value": "Edit this image: ",
-            }
+        golden = {
+            "role": "textbox",
+            "name": "",
+            "multiline": True,
+            "value": "Edit this image: ",
+            "children": [
+                {"role": "text", "name": "Edit this image:"},
+                {"role": "img", "name": "my fake image"},
+            ],
+            "value": "Edit this image: ",
+        }
     snapshot = page.accessibility.snapshot()
     assert snapshot["children"][0] == golden
 
@@ -253,19 +241,12 @@ def test_accessibility_plain_text_field_with_role_should_not_have_children(
     <div contenteditable="plaintext-only" role='textbox'>Edit this image:<img src="fakeimage.png" alt="my fake image"></div>"""
     )
     snapshot = page.accessibility.snapshot()
-    if browser_channel:
-        assert snapshot["children"][0] == {
-            "name": "",
-            "role": "textbox",
-            "value": "Edit this image:",
-        }
-    else:
-        assert snapshot["children"][0] == {
-            "multiline": True,
-            "name": "",
-            "role": "textbox",
-            "value": "Edit this image:",
-        }
+    assert snapshot["children"][0] == {
+        "multiline": True,
+        "name": "",
+        "role": "textbox",
+        "value": "Edit this image:",
+    }
 
 
 @pytest.mark.only_browser("chromium")
@@ -277,14 +258,11 @@ def test_accessibility_plain_text_field_without_role_should_not_have_content(
     <div contenteditable="plaintext-only">Edit this image:<img src="fakeimage.png" alt="my fake image"></div>"""
     )
     snapshot = page.accessibility.snapshot()
-    if browser_channel:
-        assert snapshot["children"][0] == {"name": "", "role": "generic"}
-    else:
-        assert snapshot["children"][0] == {
-            "name": "",
-            "role": "generic",
-            "value": "Edit this image:",
-        }
+    assert snapshot["children"][0] == {
+        "name": "",
+        "role": "generic",
+        "value": "Edit this image:",
+    }
 
 
 @pytest.mark.only_browser("chromium")
@@ -296,14 +274,11 @@ def test_accessibility_plain_text_field_with_tabindex_and_without_role_should_no
     <div contenteditable="plaintext-only" tabIndex=0>Edit this image:<img src="fakeimage.png" alt="my fake image"></div>"""
     )
     snapshot = page.accessibility.snapshot()
-    if browser_channel:
-        assert snapshot["children"][0] == {"name": "", "role": "generic"}
-    else:
-        assert snapshot["children"][0] == {
-            "name": "",
-            "role": "generic",
-            "value": "Edit this image:",
-        }
+    assert snapshot["children"][0] == {
+        "name": "",
+        "role": "generic",
+        "value": "Edit this image:",
+    }
 
 
 def test_accessibility_non_editable_textbox_with_role_and_tabIndex_and_label_should_not_have_children(
