Skip to content

[Bug]: to_be_visible assertion says "Locator expected to be visible" if visible=False #2616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MilovanovM opened this issue Oct 25, 2024 · 2 comments · Fixed by #2619
Closed

[Bug]: to_be_visible assertion says "Locator expected to be visible" if visible=False #2616

MilovanovM opened this issue Oct 25, 2024 · 2 comments · Fixed by #2619

Comments

@MilovanovM
Copy link

Version

latest

Steps to reproduce

Steps to reproduce:

  1. use the assertion to_be_visible(visible=False)

Expected behavior

get AssertionError: Locator expected to be hidden

Actual behavior

get AssertionError: Locator expected to be visible

Additional context

No response

Environment

  • Operating System: [Ubuntu 22.04]
  • CPU: [arm64]
  • Browser: [All, Chromium, Firefox, WebKit]
  • Python Version: [3.12]
  • Other info:
@mxschmitt
Copy link
Member

Looks like we need a condition here:

playwright-python/playwright/_impl/_assertions.py

Line 672 in 3352d85

"Locator expected to be visible",

@MilovanovM
Copy link
Author

MilovanovM commented Oct 25, 2024 •
edited
Loading

Just checked other implementations (Node, Java, dotNet), no issue there

@mxschmitt mxschmitt mentioned this issue Oct 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(assertions): error messages from negated matchers mxschmitt/playwright-python
2 participants
@MilovanovM @mxschmitt