Skip to content

fix: cancel protocol calls on connection / driver close #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2023
Merged

fix: cancel protocol calls on connection / driver close #1897

merged 1 commit into from
May 8, 2023

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented May 4, 2023 •
edited
Loading

Extracted from #1891

@mxschmitt mxschmitt marked this pull request as draft May 4, 2023 18:32
@mxschmitt mxschmitt force-pushed the cancel-protocol-calls-on-playwright-close branch from 1291e1a to 0297b3d Compare May 4, 2023 19:31
@mxschmitt mxschmitt marked this pull request as ready for review May 4, 2023 19:41
@mxschmitt mxschmitt changed the title fix: cancel protocol calls on playwright.stop() fix: cancel protocol calls on connection / driver close May 4, 2023
@mxschmitt mxschmitt force-pushed the cancel-protocol-calls-on-playwright-close branch from 0297b3d to 028ea1c Compare May 5, 2023 08:08
@mxschmitt mxschmitt merged commit b913f48 into main May 8, 2023
@mxschmitt mxschmitt deleted the cancel-protocol-calls-on-playwright-close branch May 8, 2023 16:21
@mxschmitt mxschmitt mentioned this pull request May 8, 2023
Closed
mxschmitt added a commit that referenced this pull request May 9, 2023
@mxschmitt
chore: follow-ups for #1897 connection changes
17e973a
mxschmitt added a commit that referenced this pull request May 9, 2023
@mxschmitt
chore: follow-ups for #1897 connection changes
cb10727
mxschmitt added a commit that referenced this pull request May 9, 2023
@mxschmitt
chore: follow-ups for #1897 connection changes (#1906)
3058517
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yury-s yury-s yury-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxschmitt @yury-s