Skip to content

chore: add ability to set expect timeout #1918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2023
Merged

chore: add ability to set expect timeout #1918

merged 2 commits into from
May 16, 2023

Conversation

mxschmitt
Copy link
Member

mxschmitt
mxschmitt commented May 15, 2023
View reviewed changes
@mxschmitt mxschmitt force-pushed the feat-expose-set-expect-timeout branch from f65e152 to 22cd110 Compare May 16, 2023 11:04
@mxschmitt mxschmitt marked this pull request as ready for review May 16, 2023 11:05
yury-s
yury-s approved these changes May 16, 2023
View reviewed changes
playwright/sync_api/__init__.py Outdated
def __init__(self) -> None:
self._options = ExpectOptions()

def set_options(self, timeout: float = None) -> None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably call it set_timeout but this can be a topic for API review.

@mxschmitt mxschmitt merged commit 177855e into main May 16, 2023
@mxschmitt mxschmitt deleted the feat-expose-set-expect-timeout branch May 16, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yury-s yury-s yury-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxschmitt @yury-s