chore: improve expect.set_options timeout reset handling #1981

mxschmitt · 2023-06-16T19:08:18Z

We do a good job in resetting the expect timeout here:

playwright-python/tests/async/test_assertions.py

Lines 801 to 810 in d4a874f

    
           async def test_should_be_able_to_set_custom_global_timeout(page: Page) -> None: 
        
               try: 
        
                   expect.set_options(timeout=111) 
        
                   with pytest.raises(AssertionError) as exc_info: 
        
                       await expect(page.locator("#a1")).to_be_visible() 
        
                   assert "LocatorAssertions.to_be_visible with timeout 111ms" in str( 
        
                       exc_info.value 
        
                   ) 
        
               finally: 
        
                   expect.set_options(timeout=None)

but it gets ignored here, which ends up that the timeout is not getting reset to the default:

playwright-python/playwright/async_api/__init__.py

Lines 104 to 105 in f1c11fb

    
           if timeout is not None: 
        
               self._timeout = timeout

So lets check if the param got actually passed over as per here.

Fixes #1973

chore: unflake docker tests

f8e6d18

mxschmitt changed the title ~~chore: unflake docker tests~~ chore: improve expect.set_options timeout reset handlign Jun 16, 2023

mxschmitt changed the title ~~chore: improve expect.set_options timeout reset handlign~~ chore: improve expect.set_options timeout reset handling Jun 16, 2023

dgozman approved these changes Jun 16, 2023

View reviewed changes

mxschmitt merged commit f8c4548 into main Jun 16, 2023

mxschmitt deleted the unflake-docker-tests branch June 16, 2023 19:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: improve expect.set_options timeout reset handling #1981

chore: improve expect.set_options timeout reset handling #1981

Uh oh!

mxschmitt commented Jun 16, 2023 •

edited

Loading

Uh oh!

Uh oh!

	async def test_should_be_able_to_set_custom_global_timeout(page: Page) -> None:
	try:
	expect.set_options(timeout=111)
	with pytest.raises(AssertionError) as exc_info:
	await expect(page.locator("#a1")).to_be_visible()
	assert "LocatorAssertions.to_be_visible with timeout 111ms" in str(
	exc_info.value
	)
	finally:
	expect.set_options(timeout=None)

chore: improve expect.set_options timeout reset handling #1981

chore: improve expect.set_options timeout reset handling #1981

Uh oh!

Conversation

mxschmitt commented Jun 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

mxschmitt commented Jun 16, 2023 •

edited

Loading