fix(react-native-windows): Fixed adding react-native-windows to a rea… #1162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct-native project on a non-Windows platform. Adding react-native-windows to a react-native project through the `react-native windows` command would fail due to a dependency on a powershell script to generate a certificate. Temporarily using the default certificate that gets outputed if the powershell New-SelfSignedCertificate command fails.
|
@sayar, |
|
Closing and reopening PR to trigger AppVeyor. |
|
@sayar, |
Codecov Report
@@ Coverage Diff @@
## master #1162 +/- ##
==========================================
- Coverage 31.92% 31.92% -0.01%
==========================================
Files 254 254
Lines 18385 18385
Branches 1546 1546
==========================================
- Hits 5870 5869 -1
Misses 12375 12375
- Partials 140 141 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ct-native project on a non-Windows platform.
Adding react-native-windows to a react-native project through the
react-native windowscommand would fail due to a dependency on a powershell script to generate a certificate. Temporarily using the default certificate that gets outputed if the powershell New-SelfSignedCertificate command fails.