Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal scroll bar appears on top after hiding and displaying it #12574

Closed
Tyriar opened this issue Sep 25, 2016 · 3 comments
Closed

Terminal scroll bar appears on top after hiding and displaying it #12574

Tyriar opened this issue Sep 25, 2016 · 3 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority terminal General terminal issues that don't fall under another label verified Verification succeeded
Milestone
September 2016

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 25, 2016

No description provided.

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority terminal General terminal issues that don't fall under another label labels Sep 25, 2016
@Tyriar Tyriar added this to the September 2016 milestone Sep 25, 2016
@Tyriar Tyriar self-assigned this Sep 25, 2016
@Tyriar
Copy link
Member Author

Tyriar commented Sep 26, 2016

I think what's happening here is that hiding the element is setting the viewport's scroll area scrollTop to 0, then displaying it again triggers a refresh but nothing has changed so it doesn't try to update the scrollTop value.

@Tyriar
Copy link
Member Author

Tyriar commented Sep 26, 2016

That is wrong, setting display none then block works fine.

@Tyriar
Copy link
Member Author

Tyriar commented Sep 26, 2016

It appears the panel is removed from the DOM and not hidden when the panel is hidden, this would reset the state of the scroll bar.

@Tyriar Tyriar mentioned this issue Sep 26, 2016
Open
@Tyriar Tyriar closed this as completed in 8d6aa11 Sep 26, 2016
@Tyriar Tyriar mentioned this issue Sep 28, 2016
Closed
@roblourens roblourens added the verified Verification succeeded label Sep 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority terminal General terminal issues that don't fall under another label verified Verification succeeded
Projects
None yet
Milestone
September 2016
Development

No branches or pull requests
2 participants
@roblourens @Tyriar