Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to run it in 2023 #15

Open
JaimeObregon opened this issue Nov 14, 2023 · 2 comments
Open

How to run it in 2023 #15

JaimeObregon opened this issue Nov 14, 2023 · 2 comments

Comments

@JaimeObregon
Copy link

This repo seems unmantained and won't run on a modern setup:

$ node -v
v17.2.0
$ yarn -v
1.22.15
$ git clone https://github.com/mikedotJS/adventurejs.git
Cloning into 'adventurejs'...
remote: Enumerating objects: 271, done.
remote: Total 271 (delta 0), reused 0 (delta 0), pack-reused 271
Receiving objects: 100% (271/271), 1.05 MiB | 872.00 KiB/s, done.
Resolving deltas: 100% (108/108), done.
$ cd adventurejs
$ yarn
yarn install v1.22.15
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 🔨  Building fresh packages...
[1/4] ⠠ fsevents
[-/4] ⠠ waiting...
[3/4] ⠠ deasync
error /private/tmp/adventurejs/node_modules/deasync: Command failed.
[…]

Packages deasync and fsevents won't install. The latter points to https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.2.4/fse-v1.2.4-node-v102-darwin-x64.tar.gz — which is broken.
@JaimeObregon
Copy link
Author

JaimeObregon commented Nov 15, 2023 •
edited
Loading

For anyone interested, I managed to run it by specifying exact versions of the dependencies:

diff --git a/package.json b/package.json
index 101ca7e..907b645 100644
--- a/package.json
+++ b/package.json
@@ -21,16 +21,16 @@
   },
   "homepage": "https://github.com/mikedotJS/adventurejs#readme",
   "devDependencies": {
-    "babel-cli": "^6.26.0",
-    "babel-plugin-transform-class-properties": "^6.24.1",
-    "babel-plugin-transform-object-rest-spread": "^6.26.0",
-    "babel-plugin-transform-runtime": "^6.23.0",
-    "babel-preset-env": "^1.7.0",
-    "babel-preset-flow": "^6.23.0",
-    "flow-bin": "^0.80.0",
+    "babel-cli": "6.26.0",
+    "babel-plugin-transform-class-properties": "6.24.1",
+    "babel-plugin-transform-object-rest-spread": "6.26.0",
+    "babel-plugin-transform-runtime": "6.23.0",
+    "babel-preset-env": "1.7.0",
+    "babel-preset-flow": "6.23.0",
+    "flow-bin": "0.80.0",
     "husky": "next",
-    "lint-staged": "^7.2.2",
-    "parcel-bundler": "^1.9.7",
+    "lint-staged": "7.2.2",
+    "parcel-bundler": "1.9.7",
     "prettier": "1.14.2"
   }
 }

I then removed the lockfile, installed Node.js version 16, and installed all dependencies:

rm yarn.lock
nvm install 16
yarn install

I considered submitting a pull request to update the README.md instructions, but previous pull requests appear to remain unmerged.

After that a local server spins up and I can navigate to localhost:1234. But there I only see a static <canvas> element (as shown in the attached image). The browser console shows no error. Unfortunately, there's no interactivity, instructions, or documentation available.

Xnapper-2023-11-15-09 26 40

@JaimeObregon JaimeObregon changed the title Dependencies are outdated and install is broken How to run it in 2023 Nov 15, 2023
@JaimeObregon
Copy link
Author

The trick is to press F3. Doing so brings up a layer displaying debug information in the top-left corner of the screen, which includes some instructions, as depicted here:

Xnapper-2023-11-15-09 47 55

However, it's still unclear whether I'm missing something or which features are fully implemented. For instance, I'm not sure how to make the characters walk, if that feature is even available.

I hope this information is helpful to others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JaimeObregon