Skip to content

[CI] fixing tests #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 20, 2020
Merged

[CI] fixing tests #162

merged 5 commits into from
Aug 20, 2020

Conversation

djarecka
Copy link
Collaborator

@djarecka djarecka commented Aug 11, 2020 •
edited
Loading

  • fixing the test_notebooks, so it exits with the same code as pytest itself

  • fixing the failing notebooks

@djarecka djarecka mentioned this pull request Aug 11, 2020
Closed
@djarecka
Copy link
Collaborator Author

fyi: it doesn't work, because the caching action I used is having an issue. Will wait a bit longer and see if they fix it

@djarecka djarecka merged commit 17c5be2 into miykael:master Aug 20, 2020
@djarecka
Copy link
Collaborator Author

@mgxd @effigies - fyi: the tutorial is fixed and we are actually testing the notebooks again, not just pytest..;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@djarecka