-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tornado 5.0 raises error on install with older Python versions. #1427
Conversation
changed to `"tornado>=4.1,<5.0"` in setup.py
As per the release notes, Tornado 5.0 was released two days ago (2018/03/05). Some noteworthy points include:
Without an error report, I'm not sure if the reported problem is due to one of those issues or something else. If it is one of those issues, then you should be updating your Python version, not staying with an older Tornado version. If, on the other hand, the error is related to some other problem, then our code should be updated to work with the new way forward. I'm not accepting this PR as-is (yet), but I'll leave it open as a bug report. We need to investigate what specifically is causing the problem before determining the proper approach. |
FYI, I just copied the above fix ("changed to |
MkDocs version |
On one system with an older "insecure platform" (Python 2.7.1), I get the following when trying to install Tornado 5.0:
That error makes it pretty clear that the user needs to update to a "secure" version of Python. I'm okay with that. Will need to test on other platforms later when I have time/access. Btw, in the next major release (version 1.0) of MkDocs, I expect we will be dropping support for any Python versions which Tornado doesn't support (we might even change the dependency to |
I just tested on a system which has Python 2.7.13 and 3.6.1 installed and I got no errors. I was able to install Tornado 5.0 and I was able to run That being the case, MkDocs 1.0 will drop support for any Python version not supported by Tornado 5.0. |
Sorry for taking so long to get back.
Thank you really much for your quick response and actions taken. |
The problem with requiring tornado < 5.0 is that if another dependency requires tornado and is installed first, then it's going to install tornado 5.x anyways since pip does not resolve dependencies. And at this point, even if you don't care about tornado, you cannot build the documentation any longer!
Is it possible to fix |
@pquentin the problem is twofold:
Currently the only version of MkDocs which contains the To be clear, as stated multiple times above, the next major release of MkDocs will expect Tornado 5.0+ (although it should still work fine with older versions). |
Also up tornado version to >=5.0. Fixes mkdocs#1427.
Also up tornado version to >=5.0. Fixes mkdocs#1427.
Also up tornado version to >=5.0. Fixes #1427.
@waylan Thanks, that makes sense! I appreciated the calm explanation. I now realize the tone of my message was not appropriate: please accept my apologies. |
changed to
"tornado>=4.1,<5.0"
in setup.pyThis broke installation via pip for me.