Page titles no longer contain the site name #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a page has a specific title, `page_title` will contain this and only this. If the page has no title, or is the homepage, `page_title` will be `None`. The `<title>` tag will always display at least the site name. All of the themes' base.html files have been updated accordingly.
|
cool, my main concern is backards compatability. Custom themes could loose the site name, if this is just made clear in the release notes I think it should be okay tho' - not exactly a big issue. |
d0ugal
added a commit
that referenced
this pull request
Jan 3, 2015
Page titles no longer contain the site name
|
Decided the risk is minimal - will document this in the release notes for 0.12. Thanks @samhatfield! |
|
My pleasure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a page has a specific title,
page_titlewill contain this and onlythis. If the page has no title, or is the homepage,
page_titlewill beNone. The<title>tag will always display at least the site name.All of the themes' base.html files have been updated accordingly.