Pass config file path through SubConfig to Config #3265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures FilesystemObject fields in Config are correctly evaluated relative to file.
|
Thanks for the PR. Well, the more important thing here would be adding a test that would've failed before. Also I'll need to think for a bit whether there are any implications for passing |
|
@oprypin Thanks! Please confirm that my legacy unit test is actually a legacy unit test, I've not used that style before. Hopefully this will be non-breaking. |
|
Hi sorry, I'm overthinking how to deal with a pull request. Would it be OK for me to just push my edits to this pull request? |
|
Yeah should be fine. I don't recall if I have a local copy so please don't force push. |
|
Alright I've backed up my branch locally. you can push what you like ;-) |
oprypin
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures FilesystemObject fields in Config are correctly evaluated relative to mkdocs.yaml.
See #3264