Skip to content
/ mkdocs Public
  • Sponsor
  • Notifications You must be signed in to change notification settings
  • Fork 2.5k
  • Star 20k
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abort livereload request before navigation #3390

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Abort livereload request before navigation #3390

merged 3 commits into from
Sep 14, 2023

Conversation

squidfunk
Copy link
Contributor

@squidfunk squidfunk commented Sep 13, 2023 •
edited
Loading

Closes #3389.

Edit: superseded by #3391.

@squidfunk squidfunk requested a review from oprypin September 13, 2023 10:57
@squidfunk squidfunk mentioned this pull request Sep 13, 2023
Merged
oprypin
oprypin approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@oprypin oprypin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I don't think anything could go wrong with this change

@oprypin oprypin mentioned this pull request Sep 13, 2023
Closed
ultrabug
ultrabug approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@ultrabug ultrabug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright for a first move while #3391 is resolved

@oprypin oprypin merged commit 8c79426 into master Sep 14, 2023
@oprypin oprypin deleted the fix/livereload-race-condition branch September 14, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oprypin oprypin

@ultrabug ultrabug

@karpetrosyan karpetrosyan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mkdocs serve --livereload hangs, forces to CTRL-C and restart
4 participants
@squidfunk @oprypin @ultrabug @karpetrosyan