Provide the source file name to the JS in readthedocs theme #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
readthedocs.org needs the file name in order to identify the correct source file to link to the same file in other versions of the same documentation or to the source on GitHub. Related readthedocs/readthedocs.org#1480
gregmuellegger
added a commit
to readthedocs/readthedocs.org
that referenced
this pull request
Sep 7, 2015
The problem was that we didn't had access to the correct page name (the relative path to the source file without the .md suffix). In order for this fix to work mkdocs needs to integrate mkdocs/mkdocs#721 and create a new release.
This was referenced Sep 7, 2015
gregmuellegger
added a commit
to readthedocs/readthedocs.org
that referenced
this pull request
Sep 7, 2015
The problem was that we didn't had access to the correct page name (the relative path to the source file without the .md suffix). In order for this fix to work mkdocs needs to integrate mkdocs/mkdocs#721 and create a new release.
|
Looks fine to me. Was mkdocs_page_url not useful? We can remove that if it didn't help. |
|
Hi, the With the page url we would propably be able to get to the same value by stripping the leading and trailing slash, but that feels to dirty and might break if mkdocs once decides that it will append You can remove the |
d0ugal
added a commit
that referenced
this pull request
Sep 22, 2015
Provide the source file name to the JS in readthedocs theme
|
Sorry for the delay in getting back to this. Thanks - I'll try and get a release out soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readthedocs.org needs the file name in order to identify the correct source file to link to the same file in other versions of the same documentation or to the source on GitHub.
See readthedocs/readthedocs.org#1480 for more information.