Skip to content

Fix wrong license #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Fix wrong license #12

merged 1 commit into from
Jan 25, 2021

Conversation

disko
Copy link
Contributor

@disko disko commented Jan 21, 2021

RPL is the „Repoze Public License“, a BSD based license in this case.

What kind of change does this PR introduce?

  • Add a project
  • Update a project
  • Remove a project
  • Add or update a category
  • Change configuration
  • Documentation
  • Other, please describe:

Description:

Checklist:

  • I have read the CONTRIBUTING guidelines.
  • I have not modified the README.md file. Projects are only supposed to be added or updated within the projects.yaml file since the README.md file is automatically generated.

RPL is the „Repoze Public License“, a BSD based license in this case.
@raethlein
Copy link
Member

Hey @disko, thanks for the update! I just compared the license text of RPL with the "standard" BSD licenses and it contains - as the "derived from BSD" suggests - a few different phrases which you might not expect from a standard BSD license. So, I am not sure whether we should update the information here or keep it and leave it to the users of the library to decide whether the license is a right fit, even if that might affect the ranking of the lib in the list.
Probably this is too strict but as this could happen in more cases in the future, it might make sense to at least briefly discuss whether the actual license or the group a license belongs to should be used. @lukasmasuch any thoughts?

@disko
Copy link
Contributor Author

disko commented Jan 22, 2021

Thanks for your reply @raethlein.

I see the problem. However, the currently associated "Reciprocal Public License" is definitively "more wrong". I tried to submit the "Repopze Public License" to https://tldrlegal.com/, but they're currently not accepting new license submission.

Is it possible to link to https://www.openhub.net/licenses/repoze-public-license or https://github.com/Kotti/Kotti/blob/master/LICENSE.txt instead of just specifying the license's short name?

@lukasmasuch
Copy link
Contributor

@disko @raethlein I will add something in the next best-of-generator update to allow setting custom URLs for the license. In the meantime, since @disko seems to be one of the main contributors of Kotti, it is fine from my side to apply this update and temporarily use BSD on this list.

@raethlein
Copy link
Member

@disko @lukasmasuch Alright, I opened an issue in the generator repo and we can merge and close this for now.

@raethlein raethlein merged commit ad5ccd9 into ml-tooling:main Jan 25, 2021
@disko disko deleted the patch-1 branch January 25, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants