Add notes list

yorah · nulltoken · commit 8220ec67f7c0 · 2012-05-22T19:30:19.000+02:00
diff --git a/LibGit2Sharp.Tests/NoteFixture.cs b/LibGit2Sharp.Tests/NoteFixture.cs
@@ -1,6 +1,7 @@
 ﻿using System;
 using System.Linq;
 using LibGit2Sharp.Core;
+using LibGit2Sharp.Core.Compat;
 using LibGit2Sharp.Tests.TestHelpers;
 using Xunit;
 
@@ -223,5 +224,20 @@ public void RemovingANonExistingNoteDoesntThrow()
                 repo.Notes.Delete(commit.Id, signatureNullToken, signatureYorah, "answer2");
             }
         }
+
+        [Fact]
+        public void CanRetrieveTheListOfNotesForAGivenNamespace()
+        {
+            var expectedNotes = new[] { new Tuple<string, string>("1a550e416326cdb4a8e127a04dd69d7a01b11cf4", "4a202b346bb0fb0db7eff3cffeb3c70babbd2045"),
+                new Tuple<string, string>("272a41cf2b22e57f2bc5bf6ef37b63568cd837e4", "8496071c1b46c854b31185ea97743be6a8774479") };
+
+            using (var repo = new Repository(BareTestRepoPath))
+            {
+                Assert.Equal(expectedNotes, repo.Notes["commits"].Select(n => new Tuple<string, string>(n.BlobId.Sha, n.TargetObjectId.Sha)).ToArray());
+
+                Assert.Equal("commits", repo.Notes.DefaultNamespace);
+                Assert.Equal(expectedNotes, repo.Notes.Select(n => new Tuple<string, string>(n.BlobId.Sha, n.TargetObjectId.Sha)).ToArray());
+            }
+        }
     }
 }
diff --git a/LibGit2Sharp/NoteCollection.cs b/LibGit2Sharp/NoteCollection.cs
@@ -32,7 +32,7 @@ internal NoteCollection(Repository repo)
         /// <returns>An <see cref = "IEnumerator{T}" /> object that can be used to iterate through the collection.</returns>
         public IEnumerator<Note> GetEnumerator()
         {
-            throw new NotImplementedException();
+            return this[DefaultNamespace].GetEnumerator();
         }
 
         /// <summary>
@@ -92,16 +92,33 @@ public IEnumerable<Note> this[ObjectId id]
             }
         }
 
-        internal Note RetrieveNote(ObjectId id, string canonicalNamespace)
+        /// <summary>
+        ///   Gets the collection of <see cref = "Note"/> associated with the specified namespace.
+        ///   <para>This is similar to the 'get notes list' command.</para>
+        /// </summary>
+        public IEnumerable<Note> this[string @namespace]
+        {
+            get
+            {
+                Ensure.ArgumentNotNull(@namespace, "@namespace");
+
+                string canonicalNamespace = NormalizeToCanonicalName(@namespace);
+                var notesOidRetriever = new NotesOidRetriever(repo, canonicalNamespace);
+
+                return notesOidRetriever.Retrieve().Select(oid => RetrieveNote(new ObjectId(oid), canonicalNamespace));
+            }
+        }
+
+        internal Note RetrieveNote(ObjectId targetObjectId, string canonicalNamespace)
         {
-            using (NoteSafeHandle noteHandle = BuildNoteSafeHandle(id, canonicalNamespace))
+            using (NoteSafeHandle noteHandle = BuildNoteSafeHandle(targetObjectId, canonicalNamespace))
             {
                 if (noteHandle == null)
                 {
                     return null;
                 }
 
-                return Note.BuildFromPtr(repo, UnCanonicalizeName(canonicalNamespace), id, noteHandle);
+                return Note.BuildFromPtr(repo, UnCanonicalizeName(canonicalNamespace), targetObjectId, noteHandle);
             }
         }
 
@@ -184,7 +201,7 @@ public Note Create(ObjectId targetId, string message, Signature author, Signatur
                 Ensure.Success(NativeMethods.git_note_create(out noteOid, repo.Handle, authorHandle, committerHandle, canonicalNamespace, ref oid, message));
             }
 
-            return this[targetId].First(n => n.Namespace == @namespace);
+            return RetrieveNote(targetId, canonicalNamespace);
         }
 
         /// <summary>
@@ -219,5 +236,27 @@ public void Delete(ObjectId targetId, Signature author, Signature committer, str
 
             Ensure.Success(res);
         }
+
+        private class NotesOidRetriever
+        {
+            private readonly List<GitOid> notesOid = new List<GitOid>();
+
+            internal NotesOidRetriever(Repository repo, string canonicalNamespace)
+            {
+                Ensure.Success(NativeMethods.git_note_foreach(repo.Handle, canonicalNamespace, NoteListCallBack, IntPtr.Zero));
+            }
+
+            private int NoteListCallBack(GitNoteData noteData, IntPtr intPtr)
+            {
+                notesOid.Add(noteData.TargetOid);
+
+                return 0;
+            }
+
+            public IEnumerable<GitOid> Retrieve()
+            {
+                return notesOid;
+            }
+        }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ internal NoteCollection(Repository repo)`
`32`	`32`	`/// <returns>An <see cref = "IEnumerator{T}" /> object that can be used to iterate through the collection.</returns>`
`33`	`33`	`public IEnumerator<Note> GetEnumerator()`
`34`	`34`	`{`
`35`		`- throw new NotImplementedException();`
	`35`	`+ return this[DefaultNamespace].GetEnumerator();`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`/// <summary>`
`@@ -92,16 +92,33 @@ public IEnumerable<Note> this[ObjectId id]`
`92`	`92`	`}`
`93`	`93`	`}`
`94`	`94`
`95`		`- internal Note RetrieveNote(ObjectId id, string canonicalNamespace)`
	`95`	`+ /// <summary>`
	`96`	`+ /// Gets the collection of <see cref = "Note"/> associated with the specified namespace.`
	`97`	`+ /// <para>This is similar to the 'get notes list' command.</para>`
	`98`	`+ /// </summary>`
	`99`	`+ public IEnumerable<Note> this[string @namespace]`
	`100`	`+ {`
	`101`	`+ get`
	`102`	`+ {`
	`103`	`+ Ensure.ArgumentNotNull(@namespace, "@namespace");`
	`104`	`+`
	`105`	`+ string canonicalNamespace = NormalizeToCanonicalName(@namespace);`
	`106`	`+ var notesOidRetriever = new NotesOidRetriever(repo, canonicalNamespace);`
	`107`	`+`
	`108`	`+ return notesOidRetriever.Retrieve().Select(oid => RetrieveNote(new ObjectId(oid), canonicalNamespace));`
	`109`	`+ }`
	`110`	`+ }`
	`111`	`+`
	`112`	`+ internal Note RetrieveNote(ObjectId targetObjectId, string canonicalNamespace)`
`96`	`113`	`{`
`97`		`- using (NoteSafeHandle noteHandle = BuildNoteSafeHandle(id, canonicalNamespace))`
	`114`	`+ using (NoteSafeHandle noteHandle = BuildNoteSafeHandle(targetObjectId, canonicalNamespace))`
`98`	`115`	`{`
`99`	`116`	`if (noteHandle == null)`
`100`	`117`	`{`
`101`	`118`	`return null;`
`102`	`119`	`}`
`103`	`120`
`104`		`- return Note.BuildFromPtr(repo, UnCanonicalizeName(canonicalNamespace), id, noteHandle);`
	`121`	`+ return Note.BuildFromPtr(repo, UnCanonicalizeName(canonicalNamespace), targetObjectId, noteHandle);`
`105`	`122`	`}`
`106`	`123`	`}`
`107`	`124`
`@@ -184,7 +201,7 @@ public Note Create(ObjectId targetId, string message, Signature author, Signatur`
`184`	`201`	`Ensure.Success(NativeMethods.git_note_create(out noteOid, repo.Handle, authorHandle, committerHandle, canonicalNamespace, ref oid, message));`
`185`	`202`	`}`
`186`	`203`
`187`		`- return this[targetId].First(n => n.Namespace == @namespace);`
	`204`	`+ return RetrieveNote(targetId, canonicalNamespace);`
`188`	`205`	`}`
`189`	`206`
`190`	`207`	`/// <summary>`
`@@ -219,5 +236,27 @@ public void Delete(ObjectId targetId, Signature author, Signature committer, str`
`219`	`236`
`220`	`237`	`Ensure.Success(res);`
`221`	`238`	`}`
	`239`	`+`
	`240`	`+ private class NotesOidRetriever`
	`241`	`+ {`
	`242`	`+ private readonly List<GitOid> notesOid = new List<GitOid>();`
	`243`	`+`
	`244`	`+ internal NotesOidRetriever(Repository repo, string canonicalNamespace)`
	`245`	`+ {`
	`246`	`+ Ensure.Success(NativeMethods.git_note_foreach(repo.Handle, canonicalNamespace, NoteListCallBack, IntPtr.Zero));`
	`247`	`+ }`
	`248`	`+`
	`249`	`+ private int NoteListCallBack(GitNoteData noteData, IntPtr intPtr)`
	`250`	`+ {`
	`251`	`+ notesOid.Add(noteData.TargetOid);`
	`252`	`+`
	`253`	`+ return 0;`
	`254`	`+ }`
	`255`	`+`
	`256`	`+ public IEnumerable<GitOid> Retrieve()`
	`257`	`+ {`
	`258`	`+ return notesOid;`
	`259`	`+ }`
	`260`	`+ }`
`222`	`261`	`}`
`223`	`262`	`}`