Skip to content

Commit 9170dd6

Browse files
dahlbyknulltoken
dahlbyk
authored and
nulltoken
committed
Use readonly for applicable fields
1 parent 8f622a8 commit 9170dd6

File tree

7 files changed

+25
-25
lines changed

7 files changed

+25
-25
lines changed

‎LibGit2Sharp/CheckoutCallbacks.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ internal class CheckoutCallbacks
1313
/// <summary>
1414
/// Managed delegate to call in response to checkout progress_cb callback.
1515
/// </summary>
16-
private CheckoutProgressHandler onCheckoutProgress;
16+
private readonly CheckoutProgressHandler onCheckoutProgress;
1717

1818
/// <summary>
1919
/// Constructor to set up native callback for given managed delegate.

‎LibGit2Sharp/Core/GitOdbBackend.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ static GitOdbBackend()
1919
/// This field is populated by libgit2 at backend addition time, and exists for its
2020
/// use only. From this side of the interop, it is unreferenced.
2121
/// </summary>
22-
private IntPtr Odb;
22+
private readonly IntPtr Odb;
2323

2424
#pragma warning restore 169
2525

‎LibGit2Sharp/Network.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -204,17 +204,17 @@ public virtual void Push(
204204
/// </summary>
205205
private class PushCallbacks
206206
{
207-
PushStatusErrorHandler OnError;
207+
readonly PushStatusErrorHandler onError;
208208

209209
public PushCallbacks(PushStatusErrorHandler onError)
210210
{
211-
OnError = onError;
211+
this.onError = onError;
212212
}
213213

214214
public int Callback(IntPtr referenceNamePtr, IntPtr msgPtr, IntPtr payload)
215215
{
216216
// Exit early if there is no callback.
217-
if (OnError == null)
217+
if (onError == null)
218218
{
219219
return 0;
220220
}
@@ -233,7 +233,7 @@ public int Callback(IntPtr referenceNamePtr, IntPtr msgPtr, IntPtr payload)
233233
{
234234
string referenceName = Utf8Marshaler.FromNative(referenceNamePtr);
235235
string msg = Utf8Marshaler.FromNative(msgPtr);
236-
OnError(new PushStatusError(referenceName, msg));
236+
onError(new PushStatusError(referenceName, msg));
237237
}
238238

239239
return 0;

‎LibGit2Sharp/OdbBackend.cs

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -184,15 +184,15 @@ private static class BackendEntryPoints
184184
// to native memory with StructureToPtr), we need to bind to static delegates. If at construction time
185185
// we were to bind to the methods directly, that's the same as newing up a fresh delegate every time.
186186
// Those delegates won't be rooted in the object graph and can be collected as soon as StructureToPtr finishes.
187-
public static GitOdbBackend.read_callback ReadCallback = new GitOdbBackend.read_callback(Read);
188-
public static GitOdbBackend.read_prefix_callback ReadPrefixCallback = new GitOdbBackend.read_prefix_callback(ReadPrefix);
189-
public static GitOdbBackend.read_header_callback ReadHeaderCallback = new GitOdbBackend.read_header_callback(ReadHeader);
190-
public static GitOdbBackend.readstream_callback ReadStreamCallback = new GitOdbBackend.readstream_callback(ReadStream);
191-
public static GitOdbBackend.write_callback WriteCallback = new GitOdbBackend.write_callback(Write);
192-
public static GitOdbBackend.writestream_callback WriteStreamCallback = new GitOdbBackend.writestream_callback(WriteStream);
193-
public static GitOdbBackend.exists_callback ExistsCallback = new GitOdbBackend.exists_callback(Exists);
194-
public static GitOdbBackend.foreach_callback ForEachCallback = new GitOdbBackend.foreach_callback(Foreach);
195-
public static GitOdbBackend.free_callback FreeCallback = new GitOdbBackend.free_callback(Free);
187+
public static readonly GitOdbBackend.read_callback ReadCallback = new GitOdbBackend.read_callback(Read);
188+
public static readonly GitOdbBackend.read_prefix_callback ReadPrefixCallback = new GitOdbBackend.read_prefix_callback(ReadPrefix);
189+
public static readonly GitOdbBackend.read_header_callback ReadHeaderCallback = new GitOdbBackend.read_header_callback(ReadHeader);
190+
public static readonly GitOdbBackend.readstream_callback ReadStreamCallback = new GitOdbBackend.readstream_callback(ReadStream);
191+
public static readonly GitOdbBackend.write_callback WriteCallback = new GitOdbBackend.write_callback(Write);
192+
public static readonly GitOdbBackend.writestream_callback WriteStreamCallback = new GitOdbBackend.writestream_callback(WriteStream);
193+
public static readonly GitOdbBackend.exists_callback ExistsCallback = new GitOdbBackend.exists_callback(Exists);
194+
public static readonly GitOdbBackend.foreach_callback ForEachCallback = new GitOdbBackend.foreach_callback(Foreach);
195+
public static readonly GitOdbBackend.free_callback FreeCallback = new GitOdbBackend.free_callback(Free);
196196

197197
private unsafe static int Read(
198198
out IntPtr buffer_p,
@@ -539,10 +539,10 @@ private int CallbackMethod(byte[] oid)
539539
return cb(ref gitOid, data);
540540
}
541541

542-
public ForEachCallback ManagedCallback;
542+
public readonly ForEachCallback ManagedCallback;
543543

544-
private GitOdbBackend.foreach_callback_callback cb;
545-
private IntPtr data;
544+
private readonly GitOdbBackend.foreach_callback_callback cb;
545+
private readonly IntPtr data;
546546
}
547547
}
548548

‎LibGit2Sharp/OdbBackendStream.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ public virtual OdbBackend Backend
8989
}
9090
}
9191

92-
private OdbBackend backend;
92+
private readonly OdbBackend backend;
9393
private IntPtr nativeBackendStreamPointer;
9494

9595
internal IntPtr GitOdbBackendStreamPointer
@@ -133,10 +133,10 @@ private static class BackendStreamEntryPoints
133133
// to native memory with StructureToPtr), we need to bind to static delegates. If at construction time
134134
// we were to bind to the methods directly, that's the same as newing up a fresh delegate every time.
135135
// Those delegates won't be rooted in the object graph and can be collected as soon as StructureToPtr finishes.
136-
public static GitOdbBackendStream.read_callback ReadCallback = new GitOdbBackendStream.read_callback(Read);
137-
public static GitOdbBackendStream.write_callback WriteCallback = new GitOdbBackendStream.write_callback(Write);
138-
public static GitOdbBackendStream.finalize_write_callback FinalizeWriteCallback = new GitOdbBackendStream.finalize_write_callback(FinalizeWrite);
139-
public static GitOdbBackendStream.free_callback FreeCallback = new GitOdbBackendStream.free_callback(Free);
136+
public static readonly GitOdbBackendStream.read_callback ReadCallback = new GitOdbBackendStream.read_callback(Read);
137+
public static readonly GitOdbBackendStream.write_callback WriteCallback = new GitOdbBackendStream.write_callback(Write);
138+
public static readonly GitOdbBackendStream.finalize_write_callback FinalizeWriteCallback = new GitOdbBackendStream.finalize_write_callback(FinalizeWrite);
139+
public static readonly GitOdbBackendStream.free_callback FreeCallback = new GitOdbBackendStream.free_callback(Free);
140140

141141
private unsafe static int Read(
142142
IntPtr stream,

‎LibGit2Sharp/PushResult.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,6 @@ internal PushResult(List<PushStatusError> failedPushUpdates)
4444
this.failedPushUpdates = failedPushUpdates ?? new List<PushStatusError>();
4545
}
4646

47-
private List<PushStatusError> failedPushUpdates;
47+
private readonly List<PushStatusError> failedPushUpdates;
4848
}
4949
}

‎LibGit2Sharp/TransferCallbacks.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ internal class TransferCallbacks
1515
/// <summary>
1616
/// Managed delegate to be called in response to a git_transfer_progress_callback callback from libgit2.
1717
/// </summary>
18-
private TransferProgressHandler onTransferProgress;
18+
private readonly TransferProgressHandler onTransferProgress;
1919

2020
/// <summary>
2121
/// Constructor to set up the native callback given managed delegate.

0 commit comments

Comments
 (0)