Skip to content

Commit 9bb8408

Browse files
yorahnulltoken
yorah
authored and
nulltoken
committed
Replace AssertExtensions.ShouldBeFalse method by Assert.False
1 parent d0f541b commit 9bb8408

12 files changed

+42
-47
lines changed

‎LibGit2Sharp.Tests/BranchFixture.cs

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public void CanCreateBranchFromImplicitHead()
5454
newBranch.ShouldNotBeNull();
5555
newBranch.Name.ShouldEqual(name);
5656
newBranch.CanonicalName.ShouldEqual("refs/heads/" + name);
57-
newBranch.IsCurrentRepositoryHead.ShouldBeFalse();
57+
Assert.False(newBranch.IsCurrentRepositoryHead);
5858
newBranch.Tip.ShouldNotBeNull();
5959
newBranch.Tip.Sha.ShouldEqual("4c062a6361ae6959e06292c1fa5e2822d9c96345");
6060
repo.Branches.SingleOrDefault(p => p.Name == name).ShouldNotBeNull();
@@ -108,7 +108,7 @@ public void CreatingABranchTriggersTheCreationOfADirectReference()
108108
using (var repo = new Repository(path.RepositoryPath))
109109
{
110110
Branch newBranch = repo.CreateBranch("clone-of-master");
111-
newBranch.IsCurrentRepositoryHead.ShouldBeFalse();
111+
Assert.False(newBranch.IsCurrentRepositoryHead);
112112

113113
ObjectId commitId = repo.Head.Tip.Id;
114114
newBranch.Tip.Id.ShouldEqual(commitId);
@@ -240,7 +240,7 @@ public void CanLookupLocalBranch()
240240
{
241241
Branch master = repo.Branches["master"];
242242
master.ShouldNotBeNull();
243-
master.IsRemote.ShouldBeFalse();
243+
Assert.False(master.IsRemote);
244244
master.Name.ShouldEqual("master");
245245
master.CanonicalName.ShouldEqual("refs/heads/master");
246246
master.IsCurrentRepositoryHead.ShouldBeTrue();
@@ -281,7 +281,7 @@ public void TrackingInformationIsEmptyForNonTrackingBranch()
281281
using (var repo = new Repository(BareTestRepoPath))
282282
{
283283
Branch branch = repo.Branches["test"];
284-
branch.IsTracking.ShouldBeFalse();
284+
Assert.False(branch.IsTracking);
285285
branch.TrackedBranch.ShouldBeNull();
286286
branch.AheadBy.ShouldEqual(0);
287287
branch.BehindBy.ShouldEqual(0);
@@ -349,13 +349,13 @@ public void CanCheckoutAnExistingBranch(string name)
349349
branch.ShouldNotBeNull();
350350

351351
Branch test = repo.Checkout(branch);
352-
repo.Info.IsHeadDetached.ShouldBeFalse();
352+
Assert.False(repo.Info.IsHeadDetached);
353353

354-
test.IsRemote.ShouldBeFalse();
354+
Assert.False(test.IsRemote);
355355
test.IsCurrentRepositoryHead.ShouldBeTrue();
356356
test.ShouldEqual(repo.Head);
357357

358-
master.IsCurrentRepositoryHead.ShouldBeFalse();
358+
Assert.False(master.IsCurrentRepositoryHead);
359359
}
360360
}
361361

@@ -371,13 +371,13 @@ public void CanCheckoutAnExistingBranchByName(string name)
371371
master.IsCurrentRepositoryHead.ShouldBeTrue();
372372

373373
Branch test = repo.Checkout(name);
374-
repo.Info.IsHeadDetached.ShouldBeFalse();
374+
Assert.False(repo.Info.IsHeadDetached);
375375

376-
test.IsRemote.ShouldBeFalse();
376+
Assert.False(test.IsRemote);
377377
test.IsCurrentRepositoryHead.ShouldBeTrue();
378378
test.ShouldEqual(repo.Head);
379379

380-
master.IsCurrentRepositoryHead.ShouldBeFalse();
380+
Assert.False(master.IsCurrentRepositoryHead);
381381
}
382382
}
383383

@@ -396,14 +396,14 @@ public void CanCheckoutAnArbitraryCommit(string commitPointer)
396396

397397
repo.Info.IsHeadDetached.ShouldBeTrue();
398398

399-
detachedHead.IsRemote.ShouldBeFalse();
399+
Assert.False(detachedHead.IsRemote);
400400
detachedHead.CanonicalName.ShouldEqual(detachedHead.Name);
401401
detachedHead.CanonicalName.ShouldEqual("(no branch)");
402402
detachedHead.Tip.Sha.ShouldEqual(repo.Lookup(commitPointer).Sha);
403403

404404
detachedHead.ShouldEqual(repo.Head);
405405

406-
master.IsCurrentRepositoryHead.ShouldBeFalse();
406+
Assert.False(master.IsCurrentRepositoryHead);
407407
detachedHead.IsCurrentRepositoryHead.ShouldBeTrue();
408408
repo.Head.IsCurrentRepositoryHead.ShouldBeTrue();
409409
}
@@ -520,7 +520,7 @@ public void TwoBranchesPointingAtTheSameCommitAreNotBothCurrent()
520520
Branch master = repo.Branches["refs/heads/master"];
521521

522522
Branch newBranch = repo.Branches.Create("clone-of-master", master.Tip.Sha);
523-
newBranch.IsCurrentRepositoryHead.ShouldBeFalse();
523+
Assert.False(newBranch.IsCurrentRepositoryHead);
524524
}
525525
}
526526

‎LibGit2Sharp.Tests/CommitFixture.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -504,7 +504,7 @@ public void CanCommitALittleBit()
504504
AssertBlobContent(commit[relativeFilepath], "nulltoken\n");
505505

506506
commit.ParentsCount.ShouldEqual(0);
507-
repo.Info.IsEmpty.ShouldBeFalse();
507+
Assert.False(repo.Info.IsEmpty);
508508

509509
File.WriteAllText(filePath, "nulltoken commits!\n");
510510
repo.Index.Stage(relativeFilepath);

‎LibGit2Sharp.Tests/ConfigurationFixture.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,14 +56,14 @@ public void CanDeleteConfiguration()
5656
var path = BuildTemporaryCloneOfTestRepo(StandardTestRepoPath);
5757
using (var repo = new Repository(path.RepositoryPath))
5858
{
59-
repo.Config.Get<bool>("unittests.boolsetting", false).ShouldBeFalse();
59+
Assert.False(repo.Config.Get<bool>("unittests.boolsetting", false));
6060

6161
repo.Config.Set("unittests.boolsetting", true);
6262
repo.Config.Get<bool>("unittests.boolsetting", false).ShouldBeTrue();
6363

6464
repo.Config.Delete("unittests.boolsetting");
6565

66-
repo.Config.Get<bool>("unittests.boolsetting", false).ShouldBeFalse();
66+
Assert.False(repo.Config.Get<bool>("unittests.boolsetting", false));
6767
}
6868
}
6969

@@ -271,7 +271,7 @@ public void ReadingValueThatDoesntExistReturnsDefault()
271271
repo.Config.Get<string>("unittests.ghostsetting", null).ShouldBeNull();
272272
repo.Config.Get<int>("unittests.ghostsetting", 0).ShouldEqual(0);
273273
repo.Config.Get<long>("unittests.ghostsetting", 0L).ShouldEqual(0L);
274-
repo.Config.Get<bool>("unittests.ghostsetting", false).ShouldBeFalse();
274+
Assert.False(repo.Config.Get<bool>("unittests.ghostsetting", false));
275275
repo.Config.Get("unittests.ghostsetting", "42").ShouldEqual("42");
276276
repo.Config.Get("unittests.ghostsetting", 42).ShouldEqual(42);
277277
repo.Config.Get("unittests.ghostsetting", 42L).ShouldEqual(42L);

‎LibGit2Sharp.Tests/IndexFixture.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ public void CanUnstageTheRemovalOfAFile()
328328
const string filename = "deleted_staged_file.txt";
329329

330330
string fullPath = Path.Combine(repo.Info.WorkingDirectory, filename);
331-
File.Exists(fullPath).ShouldBeFalse();
331+
Assert.False(File.Exists(fullPath));
332332

333333
repo.Index.RetrieveStatus(filename).ShouldEqual(FileStatus.Removed);
334334

@@ -480,7 +480,7 @@ public void CanRemoveAFile(string filename, FileStatus initialStatus, bool shoul
480480
repo.Index.Remove(filename);
481481

482482
repo.Index.Count.ShouldEqual(count - 1);
483-
File.Exists(fullpath).ShouldBeFalse();
483+
Assert.False(File.Exists(fullpath));
484484
repo.Index.RetrieveStatus(filename).ShouldEqual(finalStatus);
485485
}
486486
}

‎LibGit2Sharp.Tests/ObjectIdFixture.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,10 @@ public void DifferentObjectIdsAreEqual()
5454
var a = new ObjectId(validSha1);
5555
var b = new ObjectId(validSha2);
5656

57-
(a.Equals(b)).ShouldBeFalse();
58-
(b.Equals(a)).ShouldBeFalse();
57+
Assert.False((a.Equals(b)));
58+
Assert.False((b.Equals(a)));
5959

60-
(a == b).ShouldBeFalse();
60+
Assert.False((a == b));
6161
(a != b).ShouldBeTrue();
6262
}
6363

@@ -80,7 +80,7 @@ public void SimilarObjectIdsAreEqual()
8080
(b.Equals(a)).ShouldBeTrue();
8181

8282
(a == b).ShouldBeTrue();
83-
(a != b).ShouldBeFalse();
83+
Assert.False((a != b));
8484
}
8585

8686
[Fact]

‎LibGit2Sharp.Tests/ReferenceFixture.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ public void DeletingAReferenceDecreasesTheRefsCount()
181181
repo.Refs.Delete(refName);
182182

183183
List<string> refs2 = repo.Refs.Select(r => r.CanonicalName).ToList();
184-
refs2.Contains(refName).ShouldBeFalse();
184+
Assert.False(refs2.Contains(refName));
185185

186186
refs2.Count.ShouldEqual(refs.Count - 1);
187187
}
@@ -490,7 +490,7 @@ public void MovingAReferenceDoesNotDecreaseTheRefsCount()
490490
repo.Refs.Move(oldName, newName);
491491

492492
List<string> refs2 = repo.Refs.Select(r => r.CanonicalName).ToList();
493-
refs2.Contains(oldName).ShouldBeFalse();
493+
Assert.False(refs2.Contains(oldName));
494494
refs2.Contains(newName).ShouldBeTrue();
495495

496496
refs.Count.ShouldEqual(refs2.Count);

‎LibGit2Sharp.Tests/RepositoryFixture.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public void CanCreateStandardRepo()
5252

5353
repo.Info.WorkingDirectory.ShouldNotBeNull();
5454
repo.Info.Path.ShouldEqual(Path.Combine(scd.RootedDirectoryPath, ".git" + Path.DirectorySeparatorChar));
55-
repo.Info.IsBare.ShouldBeFalse();
55+
Assert.False(repo.Info.IsBare);
5656

5757
AssertIsHidden(repo.Info.Path);
5858

@@ -99,7 +99,7 @@ private static void AssertInitializedRepository(Repository repo)
9999
{
100100
repo.Info.Path.ShouldNotBeNull();
101101
repo.Info.IsEmpty.ShouldBeTrue();
102-
repo.Info.IsHeadDetached.ShouldBeFalse();
102+
Assert.False(repo.Info.IsHeadDetached);
103103

104104
Reference headRef = repo.Refs["HEAD"];
105105
headRef.ShouldNotBeNull();
@@ -162,8 +162,8 @@ public void CanOpenRepository()
162162
repo.Info.Path.ShouldNotBeNull();
163163
repo.Info.WorkingDirectory.ShouldBeNull();
164164
repo.Info.IsBare.ShouldBeTrue();
165-
repo.Info.IsEmpty.ShouldBeFalse();
166-
repo.Info.IsHeadDetached.ShouldBeFalse();
165+
Assert.False(repo.Info.IsEmpty);
166+
Assert.False(repo.Info.IsHeadDetached);
167167
}
168168
}
169169

‎LibGit2Sharp.Tests/ResetFixture.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ private static void FeedTheRepository(Repository repo)
124124

125125
repo.Checkout("mybranch");
126126

127-
repo.Index.RetrieveStatus().IsDirty.ShouldBeFalse();
127+
Assert.False(repo.Index.RetrieveStatus().IsDirty);
128128
}
129129

130130
[Fact]

‎LibGit2Sharp.Tests/StatusFixture.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ public void CanRetrieveTheStatusOfANewRepository()
8181
RepositoryStatus status = repo.Index.RetrieveStatus();
8282
status.ShouldNotBeNull();
8383
status.Count().ShouldEqual(0);
84-
status.IsDirty.ShouldBeFalse();
84+
Assert.False(status.IsDirty);
8585

8686
status.Untracked.Count().ShouldEqual(0);
8787
status.Modified.Count().ShouldEqual(0);

‎LibGit2Sharp.Tests/TagFixture.cs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public void CanCreateALightWeightTagFromSha()
2525
{
2626
Tag newTag = repo.Tags.Create("i_am_lightweight", commitE90810BSha);
2727
newTag.ShouldNotBeNull();
28-
newTag.IsAnnotated.ShouldBeFalse();
28+
Assert.False(newTag.IsAnnotated);
2929
}
3030
}
3131

@@ -37,7 +37,7 @@ public void CanCreateALightWeightTagFromAbbreviatedSha()
3737
{
3838
Tag newTag = repo.Tags.Create("i_am_lightweight", commitE90810BSha.Substring(0, 17));
3939
newTag.ShouldNotBeNull();
40-
newTag.IsAnnotated.ShouldBeFalse();
40+
Assert.False(newTag.IsAnnotated);
4141
}
4242
}
4343

@@ -48,7 +48,7 @@ public void CanCreateALightweightTagFromABranchName()
4848
using (var repo = new Repository(path.RepositoryPath))
4949
{
5050
Tag newTag = repo.Tags.Create("i_am_lightweight", "refs/heads/master");
51-
newTag.IsAnnotated.ShouldBeFalse();
51+
Assert.False(newTag.IsAnnotated);
5252
newTag.ShouldNotBeNull();
5353
}
5454
}
@@ -61,7 +61,7 @@ public void CanCreateAndOverwriteALightweightTag()
6161
{
6262
Tag newTag = repo.Tags.Create("e90810b", commitE90810BSha, true);
6363
newTag.ShouldNotBeNull();
64-
newTag.IsAnnotated.ShouldBeFalse();
64+
Assert.False(newTag.IsAnnotated);
6565
}
6666
}
6767

@@ -74,7 +74,7 @@ public void CanCreateATagWithNameContainingASlash()
7474
const string lwTagName = "i/am/deep";
7575
Tag lwTag = repo.Tags.Create(lwTagName, commitE90810BSha);
7676
lwTag.ShouldNotBeNull();
77-
lwTag.IsAnnotated.ShouldBeFalse();
77+
Assert.False(lwTag.IsAnnotated);
7878
lwTag.Target.Sha.ShouldEqual(commitE90810BSha);
7979
lwTag.Name.ShouldEqual(lwTagName);
8080

@@ -292,7 +292,7 @@ public void CanCreateATagPointingToATree()
292292

293293
Tag tag = repo.ApplyTag("tree-tag", tree.Sha);
294294
tag.ShouldNotBeNull();
295-
tag.IsAnnotated.ShouldBeFalse();
295+
Assert.False(tag.IsAnnotated);
296296
tag.Target.Id.ShouldEqual(tree.Id);
297297

298298
repo.Lookup(tag.Target.Id).ShouldEqual(tree);
@@ -311,7 +311,7 @@ public void CanCreateATagPointingToABlob()
311311

312312
Tag tag = repo.ApplyTag("blob-tag", blob.Sha);
313313
tag.ShouldNotBeNull();
314-
tag.IsAnnotated.ShouldBeFalse();
314+
Assert.False(tag.IsAnnotated);
315315
tag.Target.Id.ShouldEqual(blob.Id);
316316

317317
repo.Lookup(tag.Target.Id).ShouldEqual(blob);
@@ -495,7 +495,7 @@ public void DeletingATagDecreasesTheTagsCount()
495495
repo.Tags.Delete(tagName);
496496

497497
List<string> tags2 = repo.Tags.Select(r => r.Name).ToList();
498-
tags2.Contains(tagName).ShouldBeFalse();
498+
Assert.False(tags2.Contains(tagName));
499499

500500
tags2.Count.ShouldEqual(tags.Count - 1);
501501
}
@@ -571,7 +571,7 @@ public void CanLookupALightweightTag()
571571
tag.Name.ShouldEqual("lw");
572572
tag.Target.Sha.ShouldEqual(commitE90810BSha);
573573

574-
tag.IsAnnotated.ShouldBeFalse();
574+
Assert.False(tag.IsAnnotated);
575575
tag.Annotation.ShouldBeNull();
576576
}
577577
}

‎LibGit2Sharp.Tests/TestHelpers/AssertExtensions.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,6 @@ public static void ShouldBeAboutEqualTo(this DateTimeOffset expected, DateTimeOf
1414
Assert.Equal(expected.Second, current.Second);
1515
}
1616

17-
public static void ShouldBeFalse(this bool currentObject)
18-
{
19-
Assert.False(currentObject);
20-
}
21-
2217
public static void ShouldBeNull(this object currentObject)
2318
{
2419
Assert.Null(currentObject);

‎LibGit2Sharp.Tests/TupleFixture.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ public void VerifyNotEquals()
4848
{
4949
var sut2 = new Tuple<int, string>(integer + 1, stringy);
5050

51-
sut.Equals(sut2).ShouldBeFalse();
52-
Equals(sut, sut2).ShouldBeFalse();
51+
Assert.False(sut.Equals(sut2));
52+
Assert.False(Equals(sut, sut2));
5353
}
5454
}
5555
}

0 commit comments

Comments
 (0)