fix(devtools-connect): give application code for custom OIDC HTTP options precedence #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions precedence Instead of using the application callback first and then potentially transforming the result with options computed by devtools-connect, do the reverse. This gives the application using devtools-connect more flexibility about how exactly to modify OIDC HTTP options. The goal here is to enable usage of HTTP proxies in conjunction with `useSystemCA` and explicit `tlsCAFile` settings; devtools-connect correctly passes the former to the OIDC plugin, but after this change, the application can also pass it to the proxy agent, if it creates one. None of our team's applications currently make use of the function variant of this options, so this will not affect existing code in any way.
addaleax
commented
May 15, 2024
| @@ -76,7 +76,7 @@ | |||
| "gen-esm-wrapper": "^1.1.0", | |||
| "mocha": "^8.4.0", | |||
| "mongodb": "^5.8.1 || ^6.0.0", | |||
| "mongodb-log-writer": "^1.2.0", | |||
| "mongodb-log-writer": "^1.4.2", | |||
There was a problem hiding this comment.
I don't even quite remember why, it must have been part of the SSDLC CodeQL work, but this was lying around in my local git checkout and there didn't really seem a reason not to just do this as a drive-by change, so I just commited it along with the actual change 🤷♀️
mcasimir
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the application callback first and then potentially transforming the result with options computed by devtools-connect, do the reverse. This gives the application using devtools-connect more flexibility about how exactly to modify OIDC HTTP options.
The goal here is to enable usage of HTTP proxies in conjunction with
useSystemCAand explicittlsCAFilesettings; devtools-connect correctly passes the former to the OIDC plugin, but after this change, the application can also pass it to the proxy agent, if it creates one.None of our team's applications currently make use of the function variant of this options, so this will not affect existing code in any way.