fix(sspi): correct auth process for SSPI

mbroadst · mbroadst · commit 2a68d8b9d5ac · 2018-11-10T12:34:22.000-05:00
The SSPI auth process should have been the same as GSSAPI, but
it instead initialized and transitioned kerberos _after_ an
initial connect to the client. Starting with MongoDB 4.0, this
simply will not work anymore, and needs to be corrected.

NODE-1479
diff --git a/lib/auth/sspi.js b/lib/auth/sspi.js
@@ -47,7 +47,7 @@ class SSPI extends AuthProvider {
   }
 }
 
-var SSIPAuthenticate = function(
+function SSIPAuthenticate(
   self,
   username,
   password,
@@ -57,111 +57,73 @@ var SSIPAuthenticate = function(
   options,
   callback
 ) {
-  // Build Authentication command to send to MongoDB
-  var command = {
-    saslStart: 1,
-    mechanism: 'GSSAPI',
-    payload: '',
-    autoAuthorize: 1
-  };
-
-  // Create authenticator
-  var mongo_auth_process = new MongoAuthProcess(
+  const authProcess = new MongoAuthProcess(
     connection.host,
     connection.port,
     gssapiServiceName,
     options
   );
 
-  // Execute first sasl step
-  server(
-    connection,
-    new Query(self.bson, '$external.$cmd', command, {
+  function authCommand(command, authCb) {
+    const query = new Query(self.bson, '$external.$cmd', command, {
       numberToSkip: 0,
       numberToReturn: 1
-    }),
-    function(err, r) {
+    });
+
+    server(connection, query, authCb);
+  }
+
+  authProcess.init(username, password, err => {
+    if (err) return callback(err, false);
+
+    authProcess.transition('', (err, payload) => {
       if (err) return callback(err, false);
-      var doc = r.result;
 
-      mongo_auth_process.init(username, password, function(err) {
-        if (err) return callback(err);
+      const command = {
+        saslStart: 1,
+        mechanism: 'GSSAPI',
+        payload,
+        autoAuthorize: 1
+      };
 
-        mongo_auth_process.transition(doc.payload, function(err, payload) {
-          if (err) return callback(err);
+      authCommand(command, (err, result) => {
+        if (err) return callback(err, false);
+        const doc = result.result;
 
-          // Perform the next step against mongod
-          var command = {
+        authProcess.transition(doc.payload, (err, payload) => {
+          if (err) return callback(err, false);
+          const command = {
             saslContinue: 1,
             conversationId: doc.conversationId,
-            payload: payload
+            payload
           };
 
-          // Execute the command
-          server(
-            connection,
-            new Query(self.bson, '$external.$cmd', command, {
-              numberToSkip: 0,
-              numberToReturn: 1
-            }),
-            function(err, r) {
+          authCommand(command, (err, result) => {
+            if (err) return callback(err, false);
+            const doc = result.result;
+
+            authProcess.transition(doc.payload, (err, payload) => {
               if (err) return callback(err, false);
-              var doc = r.result;
-
-              mongo_auth_process.transition(doc.payload, function(err, payload) {
-                if (err) return callback(err);
-
-                // Perform the next step against mongod
-                var command = {
-                  saslContinue: 1,
-                  conversationId: doc.conversationId,
-                  payload: payload
-                };
-
-                // Execute the command
-                server(
-                  connection,
-                  new Query(self.bson, '$external.$cmd', command, {
-                    numberToSkip: 0,
-                    numberToReturn: 1
-                  }),
-                  function(err, r) {
-                    if (err) return callback(err, false);
-                    var doc = r.result;
-
-                    mongo_auth_process.transition(doc.payload, function(err, payload) {
-                      // Perform the next step against mongod
-                      var command = {
-                        saslContinue: 1,
-                        conversationId: doc.conversationId,
-                        payload: payload
-                      };
-
-                      // Execute the command
-                      server(
-                        connection,
-                        new Query(self.bson, '$external.$cmd', command, {
-                          numberToSkip: 0,
-                          numberToReturn: 1
-                        }),
-                        function(err, r) {
-                          if (err) return callback(err, false);
-                          var doc = r.result;
-
-                          if (doc.done) return callback(null, true);
-                          callback(new Error('Authentication failed'), false);
-                        }
-                      );
-                    });
-                  }
-                );
+              const command = {
+                saslContinue: 1,
+                conversationId: doc.conversationId,
+                payload
+              };
+
+              authCommand(command, (err, response) => {
+                if (err) return callback(err, false);
+
+                authProcess.transition(null, err => {
+                  if (err) return callback(err, null);
+                  callback(null, response);
+                });
               });
-            }
-          );
+            });
+          });
         });
       });
-    }
-  );
-};
+    });
+  });
+}
 
 module.exports = SSPI;
