fix(connect): ensure connection errors are MongoNetworkErrors

mbroadst · mbroadst · commit 380a3867fd58 · 2019-05-08T18:49:32.000-04:00
NODE-1960
diff --git a/lib/connection/connect.js b/lib/connection/connect.js
@@ -5,6 +5,7 @@ const Connection = require('./connection');
 const Query = require('./commands').Query;
 const createClientInfo = require('../topologies/shared').createClientInfo;
 const MongoError = require('../error').MongoError;
+const MongoNetworkError = require('../error').MongoNetworkError;
 const defaultAuthProviders = require('../auth/defaultAuthProviders').defaultAuthProviders;
 const WIRE_CONSTANTS = require('../wireprotocol/constants');
 const MAX_SUPPORTED_WIRE_VERSION = WIRE_CONSTANTS.MAX_SUPPORTED_WIRE_VERSION;
@@ -283,7 +284,7 @@ function makeConnection(family, options, _callback) {
       if (err == null || err === false) err = true;
       errorEvents.forEach(event => socket.removeAllListeners(event));
       socket.removeListener('connect', connectHandler);
-      callback(err, eventName);
+      callback(new MongoNetworkError(err.message), eventName);
     };
   }
 
diff --git a/test/tests/unit/connect_tests.js b/test/tests/unit/connect_tests.js
@@ -7,6 +7,7 @@ const expect = require('chai').expect;
 const connect = require('../../../lib/connection/connect');
 const MongoCredentials = require('../../../lib/auth/mongo_credentials').MongoCredentials;
 const genClusterTime = require('./common').genClusterTime;
+const MongoNetworkError = require('../../../lib/error').MongoNetworkError;
 
 describe('Connect Tests', function() {
   const test = {};
@@ -90,4 +91,11 @@ describe('Connect Tests', function() {
       done(err);
     });
   });
+
+  it('should emit `MongoNetworkError` for network errors', function(done) {
+    connect({ host: 'non-existent', port: 27018 }, err => {
+      expect(err).to.be.instanceOf(MongoNetworkError);
+      done();
+    });
+  });
 });
