refactor(topologies): only call callbacks if provided in auth

mbroadst · mbroadst · commit 864ff9fb02f2 · 2019-03-10T14:44:55.000-04:00
diff --git a/lib/connection/pool.js b/lib/connection/pool.js
@@ -607,15 +607,15 @@ Pool.prototype.connect = function() {
  * @param {authResultCallback} callback A callback function
  */
 Pool.prototype.auth = function(credentials, callback) {
-  callback(null, null);
+  if (typeof callback === 'function') callback(null, null);
 };
 
 /**
  * Logout all users against a database
  * @param {authResultCallback} callback A callback function
  */
 Pool.prototype.logout = function(dbName, callback) {
-  callback(null, null);
+  if (typeof callback === 'function') callback(null, null);
 };
 
 /**
diff --git a/lib/topologies/mongos.js b/lib/topologies/mongos.js
@@ -300,7 +300,7 @@ Mongos.prototype.connect = function(options) {
  * @param {authResultCallback} callback A callback function
  */
 Mongos.prototype.auth = function(credentials, callback) {
-  callback(null, null);
+  if (typeof callback === 'function') callback(null, null);
 };
 
 function handleEvent(self) {
diff --git a/lib/topologies/replset.js b/lib/topologies/replset.js
@@ -940,7 +940,7 @@ ReplSet.prototype.connect = function(options) {
  * @param {authResultCallback} callback A callback function
  */
 ReplSet.prototype.auth = function(credentials, callback) {
-  callback(null, null);
+  if (typeof callback === 'function') callback(null, null);
 };
 
 /**
diff --git a/lib/topologies/server.js b/lib/topologies/server.js
@@ -505,7 +505,7 @@ Server.prototype.connect = function(options) {
  * @param {authResultCallback} callback A callback function
  */
 Server.prototype.auth = function(credentials, callback) {
-  callback(null, null);
+  if (typeof callback === 'function') callback(null, null);
 };
 
 /**
