test(OP_MSG): adding tests for getMore

daprahamian · mbroadst · commit a912ee0990d3 · 2018-11-19T10:32:02.000-05:00
diff --git a/lib/wireprotocol/3_6_support/execute_get_more.js b/lib/wireprotocol/3_6_support/execute_get_more.js
@@ -8,8 +8,7 @@ const retrieveBSON = require('../../connection/utils').retrieveBSON;
 
 const BSON = retrieveBSON();
 
-function executeGetMore(bson, ns, cursorState, batchSize, raw, connection, options, callback) {
-  options = options || {};
+function executeGetMore(bson, ns, cursorState, batchSize, raw, connection, callback) {
   // Build command namespace
   const parts = ns.split(/\./);
 
diff --git a/lib/wireprotocol/3_6_support/index.js b/lib/wireprotocol/3_6_support/index.js
@@ -29,7 +29,7 @@ class WireProtocol {
   }
 
   getMore(bson, ns, cursorState, batchSize, raw, connection, options, callback) {
-    executeGetMore(bson, ns, cursorState, batchSize, raw, connection, options, callback);
+    executeGetMore(bson, ns, cursorState, batchSize, raw, connection, callback);
   }
 
   command(bson, ns, cmd, cursorState, topology, options) {
diff --git a/test/tests/unit/wireprotocol/3_6/get_more_tests.js b/test/tests/unit/wireprotocol/3_6/get_more_tests.js
@@ -0,0 +1,176 @@
+'use strict';
+
+const expect = require('chai').expect;
+const TestHarness = require('./utils').TestHarness;
+const expectMsgToHaveSingleQuery = require('./utils').expectMsgToHaveSingleQuery;
+const executeGetMore = require('../../../../../lib/wireprotocol/3_6_support/execute_get_more');
+
+describe('Wire Protocol 3.6 GetMore', function() {
+  const test = new TestHarness();
+
+  const $db = 'darmok';
+  const collection = 'jalad';
+  const namespace = `${$db}.${collection}`;
+
+  let connection;
+
+  beforeEach(() => {
+    connection = { write: test.sinon.stub() };
+  });
+
+  it('should reflect the basic options on to the getMoreCommand', function() {
+    const cursorState = {
+      cmd: {},
+      cursorId: 8675309
+    };
+
+    const BATCH_SIZE = -23000;
+
+    executeGetMore(
+      test.bson,
+      namespace,
+      cursorState,
+      BATCH_SIZE,
+      undefined,
+      connection,
+      test.callback
+    );
+
+    expect(connection.write).to.have.been.calledOnce;
+
+    expectMsgToHaveSingleQuery(connection.write.lastCall.args[0]).to.deep.equal({
+      $db,
+      collection,
+      batchSize: 23000,
+      getMore: cursorState.cursorId
+    });
+  });
+
+  it('should attach maxTimeMS', function() {
+    const cursorState = {
+      cmd: {
+        tailable: true,
+        maxAwaitTimeMS: 1001
+      },
+      cursorId: 8675309
+    };
+
+    const BATCH_SIZE = -23000;
+
+    executeGetMore(
+      test.bson,
+      namespace,
+      cursorState,
+      BATCH_SIZE,
+      undefined,
+      connection,
+      test.callback
+    );
+
+    expect(connection.write).to.have.been.calledOnce;
+
+    expectMsgToHaveSingleQuery(connection.write.lastCall.args[0]).to.deep.equal({
+      $db,
+      collection,
+      batchSize: 23000,
+      getMore: cursorState.cursorId,
+      maxTimeMS: cursorState.cmd.maxAwaitTimeMS
+    });
+  });
+
+  describe('callback tests', function() {
+    let queryCallback;
+
+    beforeEach(() => {
+      const cursorState = {
+        cmd: {
+          tailable: true,
+          maxAwaitTimeMS: 1001
+        },
+        cursorId: 8675309
+      };
+
+      const BATCH_SIZE = -23000;
+
+      executeGetMore(
+        test.bson,
+        namespace,
+        cursorState,
+        BATCH_SIZE,
+        undefined,
+        connection,
+        test.callback
+      );
+
+      queryCallback = connection.write.lastCall.args[2];
+    });
+
+    it('should pass along any errors to the callback', function() {
+      const err = new Error('test error 1');
+      queryCallback(err);
+
+      expect(test.callback).to.have.been.calledOnce.and.calledWithExactly(err);
+    });
+
+    it('should throw MongoNetworkError if responseFlag is nonzero', function() {
+      const err = null;
+      const response = {
+        message: {
+          documents: undefined,
+          responseFlags: 1
+        }
+      };
+
+      queryCallback(err, response);
+
+      expect(test.callback).to.have.been.calledOnce;
+
+      const returnedError = test.callback.lastCall.args[0];
+
+      expect(returnedError)
+        .to.be.an.instanceOf(test.MongoNetworkError)
+        .and.to.have.property('message')
+        .that.equals('cursor killed or timed out');
+    });
+
+    it('should return a MongoError if ok is 0', function() {
+      const err = null;
+      const badMsg = { ok: 0 };
+      const response = {
+        message: {
+          documents: [badMsg]
+        }
+      };
+
+      queryCallback(err, response);
+
+      expect(test.callback).to.have.been.calledOnce;
+
+      const returnedError = test.callback.lastCall.args[0];
+
+      expect(returnedError)
+        .to.be.an.instanceOf(test.MongoError)
+        .and.to.have.property('message')
+        .that.equals('n/a');
+    });
+
+    it('should return a valid document and connection to the callback', function() {
+      const validDoc = { ok: 1, cursor: { id: 8675309 } };
+      const err = null;
+      const response = {
+        message: {
+          documents: [validDoc],
+          connection: {}
+        }
+      };
+
+      queryCallback(err, response);
+
+      expect(test.callback).to.have.been.calledOnce.and.to.have.been.calledWithExactly(
+        null,
+        response.message.documents[0],
+        response.message.connection
+      );
+    });
+  });
+});

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ class WireProtocol {`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`getMore(bson, ns, cursorState, batchSize, raw, connection, options, callback) {`
`32`		`- executeGetMore(bson, ns, cursorState, batchSize, raw, connection, options, callback);`
	`32`	`+ executeGetMore(bson, ns, cursorState, batchSize, raw, connection, callback);`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`command(bson, ns, cmd, cursorState, topology, options) {`