test(OP_MSG): adding tests for checking moreToCome flag

daprahamian · mbroadst · commit ef58dc480097 · 2018-11-19T10:32:02.000-05:00
diff --git a/lib/connection/msg.js b/lib/connection/msg.js
@@ -32,11 +32,6 @@ const opcodes = require('../wireprotocol/shared').opcodes;
 // Incrementing request id
 let _requestId = 0;
 
-// Msg Flags
-const OPTS_CHECKSUM_PRESENT = 1;
-const OPTS_MORE_TO_COME = 2;
-const OPTS_EXHAUST_ALLOWED = 1 >> 16;
-
 class Msg {
   constructor(bson, query, options) {
     // Basic options needed to be passed in
@@ -71,15 +66,15 @@ class Msg {
     let flags = 0;
 
     if (this.checksumPresent) {
-      flags |= OPTS_CHECKSUM_PRESENT;
+      flags |= Msg.flags.CHECKSUM_PRESENT;
     }
 
     if (this.moreToCome) {
-      flags |= OPTS_MORE_TO_COME;
+      flags |= Msg.flags.MORE_TO_COME;
     }
 
     if (this.exhaustAllowed) {
-      flags |= OPTS_EXHAUST_ALLOWED;
+      flags |= Msg.flags.EXHAUST_ALLOWED;
     }
 
     const header = new Buffer(
@@ -169,6 +164,12 @@ Msg.getRequestId = function() {
   return ++_requestId;
 };
 
+Msg.flags = {
+  CHECKSUM_PRESENT: 1,
+  MORE_TO_COME: 2,
+  EXHAUST_ALLOWED: 1 << 16
+};
+
 function writeInt32ListToUint8Buffer(buffer, int32List, start) {
   let index = start || 0;
 
diff --git a/test/tests/unit/wireprotocol/3_6/msg_test.js b/test/tests/unit/wireprotocol/3_6/msg_test.js
@@ -156,5 +156,13 @@ describe('OP_MSG', function() {
     });
   });
 
+  it('should properly reflect getMore flag in BSON', function() {
+    const msg = new Msg(bson, {}, { moreToCome: true });
+    const buffers = msg.toBin();
+    const parsedMessage = parseOpMsg(buffers);
+
+    expect(parsedMessage).to.have.property('flags', Msg.flags.MORE_TO_COME);
+  });
+
   it.skip('should properly serialize multiple commands');
 });
