fix: docker security warnings #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses Docker security warnings and improves server shutdown handling.
- Adds new logging identifiers for server shutdown events
- Implements SIGINT handling in index.ts to gracefully close the server
- Enhances the Dockerfile and build workflow to run as a non-root user and include security provenance and SBOM metadata
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/logger.ts | Adds new log IDs for server close events |
| src/index.ts | Introduces SIGINT handler for graceful shutdown |
| Dockerfile | Updates Dockerfile to use non-root user and security ARG ordering issue |
| .github/workflows/docker.yaml | Configures Docker build with provenance and SBOM metadata |
Comments suppressed due to low confidence (1)
Dockerfile:3
- The ARG declaration for VERSION is moved after its usage; move 'ARG VERSION=latest' before the RUN instruction that uses it to ensure proper substitution.
RUN npm install -g mongodb-mcp-server@${VERSION}
blva
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup from #238