Skip to content

feat: Added support for Playwright #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

TriPSs
Copy link

@TriPSs TriPSs commented Dec 23, 2023

No description provided.

@@ -39,6 +39,7 @@
},
"homepage": "https://github.com/moshensky/pdf-visual-diff#readme",
"dependencies": {
"@playwright/test": "^1.40.1",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

Thank you for your contribution.
Are there any options not to depend directly on playwrigit?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ow, this one should be in the dev dependencies

@ComaToastUK
Copy link

Hi @moshensky, this would actually be really useful, any chance this will be merged?

@moshensky
Copy link
Owner

Hi @moshensky, this would actually be really useful, any chance this will be merged?

I'll have a look tomorrow.

@TriPSs
Copy link
Author

TriPSs commented Jul 25, 2024

@ComaToastUK FYI: I created to-match-pdf-snapshot which is specifically for Playwright

@moshensky
Copy link
Owner

I don’t have immediate plans to implement this functionality at the moment, so I’ll be closing the PR for now.
If anyone would like to see this feature added in the future, feel free to open new issue.
It should be easy to use the lib as is right now.

@moshensky moshensky closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants