combineUrl fix #2400
combineUrl fix #2400
Conversation
| @@ -85,6 +85,8 @@ function assert(cond, msg) { | |||
| // Combines two URLs. The baseUrl shall be absolute URL. If the url is an | |||
| // absolute URL, it will be returned as is. | |||
| function combineUrl(baseUrl, url) { | |||
| if (url == "") | |||
There was a problem hiding this comment.
I'd rather see a url.length == 0 or !url check
There was a problem hiding this comment.
Can you explain why you prefer them over url==""?
|
Really good. In this case Address the comments below and squash the commits into one (see https://github.com/mozilla/pdf.js/wiki/Squashing-Commits) |
| @@ -85,6 +85,8 @@ function assert(cond, msg) { | |||
| // Combines two URLs. The baseUrl shall be absolute URL. If the url is an | |||
| // absolute URL, it will be returned as is. | |||
| function combineUrl(baseUrl, url) { | |||
| if (url.length == 0) | |||
There was a problem hiding this comment.
change that to if (!url)
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/3b9b9d812e63a31/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/b45b450d2c6f8f3/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/3b9b9d812e63a31/output.txt Total script time: 14.32 mins
|
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/b45b450d2c6f8f3/output.txt Total script time: 14.38 mins
Image differences available at: http://107.21.233.14:8877/b45b450d2c6f8f3/reftest-analyzer.xhtml#web=eq.log |
|
looks good. thank you for the patch |
|
regression tests failed? doesn't look good |
|
that's an intermittent failure |
Trying to resolve #2279