Skip to content

Commit 29af7f9

Browse files
committed
Correct some spec
1 parent 83c239b commit 29af7f9

File tree

3 files changed

+12
-21
lines changed

3 files changed

+12
-21
lines changed

src/angular-datatables.renderer.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,8 @@ angular.module('datatables.renderer', ['datatables.factory', 'datatables.options
7676
renderer.render = function ($scope, $elem, staticHTML) {
7777
var _this = this,
7878
expression = $elem.find('tbody').html(),
79-
// Find the resources from the comment <!-- ngRepeat: item in items --> displayed by angular in the DOM
80-
// This regexp is inspired by the one used in the "ngRepeat" directive
79+
// Find the resources from the comment <!-- ngRepeat: item in items --> displayed by angular in the DOM
80+
// This regexp is inspired by the one used in the "ngRepeat" directive
8181
match = expression.match(/^\s*.+?\s+in\s+(\S*)\s*/),
8282
ngRepeatAttr = match[1];
8383

test/karma.conf.js

+1-8
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,7 @@ module.exports = function(config) {
1515
'vendor/datatables/media/js/jquery.dataTables.js',
1616
'vendor/angular/angular.js',
1717
'vendor/angular-mocks/angular-mocks.js',
18-
'src/angular-datatables.bootstrap.options.js',
19-
'src/angular-datatables.bootstrap.js',
20-
'src/angular-datatables.renderer.js',
21-
'src/angular-datatables.factory.js',
22-
'src/angular-datatables.util.js',
23-
'src/angular-datatables.directive.js',
24-
'src/angular-datatables.options.js',
25-
'src/angular-datatables.js',
18+
'src/*.js',
2619
'test/spec/*.spec.js'
2720
],
2821

test/spec/angular-datatables.renderer.spec.js

+9-11
Original file line numberDiff line numberDiff line change
@@ -76,11 +76,9 @@ describe('datatables.renderer', function () {
7676
});
7777
});
7878
it('should set the "destroy" option to true if we render again', inject(function ($timeout) {
79-
// add $timeout in order to "wait" the DataTables to be renderer before calling the following codes
80-
$timeout(function () {
81-
DTRendererService.renderDataTableAndEmitEvent($elem, options, $scope);
82-
expect(options.destroy).toBeTruthy();
83-
}, 0, false);
79+
spyOn($.fn.dataTable, 'isDataTable').andReturn(true);
80+
DTRendererService.renderDataTableAndEmitEvent($elem, options, $scope);
81+
expect(options.destroy).toBeTruthy();
8482
}));
8583
});
8684
describe(', when rendering the DataTable,', function () {
@@ -189,12 +187,12 @@ describe('datatables.renderer', function () {
189187
}));
190188

191189
it('should render the DataTable', function () {
192-
$timeout(function () {
193-
renderer = DTDefaultRenderer.create();
194-
var oTable = renderer.render($scope, $elem);
195-
expect(DTRendererService.doRenderDataTable).toHaveBeenCalledWith($elem, options, $scope);
196-
expect(oTable).toBeDefined();
197-
}, 0, false);
190+
renderer = DTDefaultRenderer.create();
191+
renderer = renderer.render($scope, $elem);
192+
$timeout.flush();
193+
expect(DTRendererService.doRenderDataTable).toHaveBeenCalled();
194+
expect(renderer).toBeDefined();
195+
expect(renderer.name).toBe('DTDefaultRenderer');
198196
});
199197
});
200198
});

0 commit comments

Comments
 (0)