fix: remove AsSystemUser from users extract mw

Emyrk · Emyrk · commit 781c1250d454 · 2023-10-09T18:50:05.000-05:00
diff --git a/coderd/httpmw/userparam.go b/coderd/httpmw/userparam.go
@@ -82,7 +82,7 @@ func ExtractUserParam(db database.Store, redirectToLoginOnMe bool) func(http.Han
 				}
 			} else if userID, err := uuid.Parse(userQuery); err == nil {
 				//nolint:gocritic // If the userQuery is a valid uuid
-				user, err = db.GetUserByID(dbauthz.AsSystemRestricted(ctx), userID)
+				user, err = db.GetUserByID(ctx, userID)
 				if err != nil {
 					httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{
 						Message: userErrorMessage,
@@ -92,7 +92,7 @@ func ExtractUserParam(db database.Store, redirectToLoginOnMe bool) func(http.Han
 				}
 			} else {
 				// nolint:gocritic // Try as a username last
-				user, err = db.GetUserByEmailOrUsername(dbauthz.AsSystemRestricted(ctx), database.GetUserByEmailOrUsernameParams{
+				user, err = db.GetUserByEmailOrUsername(ctx, database.GetUserByEmailOrUsernameParams{
 					Username: userQuery,
 				})
 				if err != nil {
diff --git a/coderd/users_test.go b/coderd/users_test.go
@@ -1192,6 +1192,20 @@ func TestGetUser(t *testing.T) {
 		require.NoError(t, err)
 		require.Equal(t, exp, user)
 	})
+	t.Run("NoAuth", func(t *testing.T) {
+		t.Parallel()
+
+		client := coderdtest.New(t, nil)
+		firstUser := coderdtest.CreateFirstUser(t, client)
+
+		ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
+		defer cancel()
+
+		uClient, _ := coderdtest.CreateAnotherUser(t, client, firstUser.OrganizationID)
+
+		_, err := uClient.User(ctx, firstUser.UserID.String())
+		require.NoError(t, err)
+	})
 }
 
 // TestUsersFilter creates a set of users to run various filters against for testing.
