BUG#35233031: Connector/Python should not default to mysql_native_password

nmariz · nmariz · commit 3fe87a163de1 · 2023-03-30T11:37:15.000+01:00
MySQL Connector/Python will default to `mysql_native_password` for
authentication when using the C extension.
This patch fixes this issue by not providing any default authentication
plugin to libmysqlclient.

Change-Id: I511cd151b6070a24a7c8da7a78a40e896f294dd5
diff --git a/CHANGES.txt b/CHANGES.txt
@@ -15,6 +15,7 @@ v8.0.33
 - WL#15483: Support OCI ephemeral key-based authentication
 - WL#15435: Improve the logging system
 - WL#15401: Support for type hints in module mysqlx
+- BUG#35233031: Connector/Python should not default to mysql_native_password
 - BUG#35015758: COM_QUIT should not be called in the connection phase
 - BUG#34984850: Fix binary conversion with NO_BACKSLASH_ESCAPES mode
 - BUG#31355895: Fix slow executemany() with insert statements
diff --git a/src/mysql_capi.c b/src/mysql_capi.c
@@ -361,7 +361,7 @@ MySQL_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
     self->result = NULL;
     self->fields = NULL;
     self->use_unicode = 1;
-    self->auth_plugin = PyUnicode_FromString("mysql_native_password");
+    self->auth_plugin = Py_None;
     self->plugin_dir = PyUnicode_FromString(".");
     self->converter_str_fallback = Py_False;
 
@@ -871,7 +871,8 @@ MySQL_change_user(MySQL *self, PyObject *args, PyObject *kwds)
         return NULL;
     }
 
-    if (strcmp(PyUnicode_AsUTF8(self->auth_plugin), "mysql_clear_password") == 0) {
+    if (self->auth_plugin != Py_None &&
+        strcmp(PyUnicode_AsUTF8(self->auth_plugin), "mysql_clear_password") == 0) {
         abool = 1;
         mysql_options(&self->session, MYSQL_ENABLE_CLEARTEXT_PLUGIN, (char *)&abool);
     }
