BUG19584116: Fix extra signal causing runtime error in Django

peeyushgupta · peeyushgupta · commit c86a2952610e · 2014-09-10T11:14:52.000+05:30
Using connection_created signal defined in django.db.backends.signals
causes maximum recursion depth reached runtime error.
We fix this by not sending the extra signal after the connection to
the database is setup.

Unit tests are updated.
diff --git a/lib/mysql/connector/django/base.py b/lib/mysql/connector/django/base.py
@@ -584,7 +584,6 @@ def get_new_connection(self, conn_params):
         cnx = mysql.connector.connect(**conn_params)
         self.server_version = cnx.get_server_version()
         cnx.set_converter_class(DjangoMySQLConverter)
-        connection_created.send(sender=self.__class__, connection=self)
 
         return cnx
 
@@ -609,6 +608,7 @@ def create_cursor(self):
     def _connect(self):
         """Setup the connection with MySQL"""
         self.connection = self.get_new_connection(self.get_connection_params())
+        connection_created.send(sender=self.__class__, connection=self)
         self.init_connection_state()
 
     def _cursor(self):
diff --git a/tests/test_django.py b/tests/test_django.py
@@ -26,6 +26,7 @@
 
 import datetime
 import sys
+import unittest
 
 import tests
 
@@ -82,6 +83,7 @@
 import django.db  # pylint: disable=W0611
 if tests.DJANGO_VERSION >= (1, 6):
     from django.db.backends import FieldInfo
+from django.db.backends.signals import connection_created
 
 import mysql.connector
 from mysql.connector.django.base import (DatabaseWrapper, DatabaseOperations,
@@ -207,6 +209,23 @@ def test__init__(self):
         exp = self.conn.converter._time_to_mysql(value)
         self.assertEqual(exp, self.cnx.ops.value_to_db_time(value))
 
+    def test_signal(self):
+        from django.db import connection
+
+        def conn_setup(*args, **kwargs):
+            conn = kwargs['connection']
+            cur = conn.cursor()
+            cur.execute("SET @xyz=10")
+            cur.close()
+
+        connection_created.connect(conn_setup)
+        cursor = connection.cursor()
+        cursor.execute("SELECT @xyz")
+
+        self.assertEqual((10,), cursor.fetchone())
+        cursor.close()
+        self.cnx.close()
+
 
 class DjangoDatabaseOperations(tests.MySQLConnectorTests):
 
