fixup! Fix suppression of fatal protocol server errors

dougwilson · dougwilson · commit 4403da34a2ea · 2020-04-16T14:07:06.000-04:00
diff --git a/lib/Connection.js b/lib/Connection.js
@@ -15,6 +15,7 @@ function Connection(options) {
 
   this.config = options.config;
 
+  this._buffer        = [];
   this._socket        = options.socket;
   this._protocol      = new Protocol({config: this.config, connection: this});
   this._connectCalled = false;
@@ -81,8 +82,16 @@ Connection.prototype.connect = function connect(options, callback) {
     }
 
     var connection = this;
-    this._protocol.on('data', function(data) {
-      connection._socket.write(data);
+    var onWrite    = function onWrite() {
+      if (connection._buffer.shift() && connection._buffer.length > 0) {
+        connection._socket.write(connection._buffer[0], onWrite);
+      }
+    };
+
+    this._protocol.on('data', function (data) {
+      if (connection._buffer.push(data) === 1) {
+        connection._socket.write(data, onWrite);
+      }
     });
     this._socket.on('data', wrapToDomain(connection, function (data) {
       connection._protocol.write(data);
@@ -415,11 +424,7 @@ Connection.prototype._handleConnectTimeout = function() {
 };
 
 Connection.prototype._handleNetworkError = function(err) {
-  if (err.code === 'EPIPE' && err.syscall === 'write') {
-    setTimeout(this._protocol.handleNetworkError.bind(this._protocol, err), 10);
-  } else {
-    this._protocol.handleNetworkError(err);
-  }
+  this._protocol.handleNetworkError(err);
 };
 
 Connection.prototype._handleProtocolError = function(err) {
