Skip to content

getFrameById() is deprecated. after updating to NS 6.2.0 #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
KEYHAN-A opened this issue Nov 11, 2019 · 6 comments · Fixed by #589
Closed

getFrameById() is deprecated. after updating to NS 6.2.0 #575

KEYHAN-A opened this issue Nov 11, 2019 · 6 comments · Fixed by #589
Assignees
@msaelices
Labels
priority:normal

Comments

@KEYHAN-A
Copy link

Version

2.4.0

Reproduction link

https://play.nativescript.org/

Platform and OS info

Android 9 / Nativescript 6.2.0 / macOS 10.15

Steps to reproduce

I'm trying to use $navigateTo() but I get this line logged in the console when I @tap on my element :
JS: 'getFrameById() is deprecated. Use Frame.getFrameById() instead.'

What is expected?

Navigate to the other page

What is actually happening?

getting this line in the console and nothing happens:
JS: 'getFrameById() is deprecated. Use Frame.getFrameById() instead.'

here is my method:

goToDetailPage() {
      this.$navigateTo(MarketDetails, {
        animated: true,
        transition: {
          name: "slide",
          curve: "ease"
        },
        props: { item: this.item, index: this.index }
      });
    },
@zeke8402
Copy link

Hey @KEYHAN-A , I just had the exact same problem, it turned out that the component I was trying to navigate to was not encased in <Page> tags. So, let me know if your component, MarketDetails, maybe missing the <Page> tag that it should be wrapped in.

Hope that helps!

@KEYHAN-A
Copy link
Author

KEYHAN-A commented Nov 13, 2019 •
edited
Loading

@zeke8402
actually I do have <page> tag in MarketDetails page,
figured out NavigateTo works when you use <ListView> but I need to use a custom list,
I'll post here if I find what the problem is.

@KEYHAN-A
Copy link
Author

KEYHAN-A commented Nov 13, 2019 •
edited
Loading

And also there's this issue with <ListView> navigation:
when I tap on items, nothing happens, then when I try to go to the other tab all of a sudden all pages start to navigate one by one, See the GIF below

Nov-13-2019 12-00-29

I'm using NSVue 6.2.0 Tabs template

@msaelices msaelices self-assigned this Nov 26, 2019
@msaelices msaelices mentioned this issue Nov 27, 2019
Merged
@coffeeneed
Copy link

Why is this issue closed when it's not resolved? I also experience this error when invoking a function with with $navigateTo. My app simply doesn't work anymore. I do not use ListView and I do have in my markup. Help, please. I'm clueless here and we need to work in our app.

PS: I have searched my code for "frame" also, but I don't have that word mentioned in my code, so there has to be something deeper.

@rigor789
Copy link
Member

@coffeeneed have you installed the latest version of nsvue this has been released in? https://github.com/nativescript-vue/nativescript-vue/releases/tag/v2.5.0-alpha.3

@nativescript-vue-bot
Copy link
Collaborator

We are locking this issue because it has been closed for more than 14 days.

If the issue comes up again please open a new issue with additional details.

@nativescript-vue nativescript-vue locked as resolved and limited conversation to collaborators Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@msaelices msaelices

Labels
priority:normal
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use NS 6.2 scoped NPM packages nativescript-vue/nativescript-vue
6 participants
@msaelices @rigor789 @zeke8402 @KEYHAN-A @coffeeneed @nativescript-vue-bot