Skip to content

Fix odd App crash while using v-if inside the RLV's template #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2019
Merged

Fix odd App crash while using v-if inside the RLV's template #554

merged 1 commit into from
Nov 29, 2019

Conversation

msaelices
Copy link

@msaelices msaelices commented Sep 25, 2019 •
edited
Loading

Fixes ProgressNS/nativescript-ui-feedback#1182

I know this fix is kind of code smells as the real reason why the referenceNode has not any parentNode is the real cause of the issue. But I wanted @rigor789 to look at and point me in the right direction.

@msaelices msaelices requested a review from rigor789 September 25, 2019 10:35
@msaelices msaelices mentioned this pull request Sep 25, 2019
Open
@rigor789 rigor789 merged commit 838d98a into master Nov 29, 2019
@rigor789 rigor789 deleted the fix-listview-nodeop-issue branch December 5, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rigor789 rigor789 Awaiting requested review from rigor789

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App crashes while using v-if inside the RadListView's template
2 participants
@msaelices @rigor789