Skip to content

Suppress render logs #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2019

Conversation

maxorlovsky
Copy link

Add option to suppress bunch of logs responsible for listing rendered elements. They are preventing developer to see actual Vue Warns in the templates.
This will tackle the problem mentioned in this issue #479

@maxorlovsky
Copy link
Author

@rigor789 tell me please if this PR is good enough or something else need to be added. Sorry if this is completely incorrect, my first PR to this project :)

@maxorlovsky
Copy link
Author

Not sure that fail of tests for SAUCE_USER not found is happening because of my change..

@rigor789
Copy link
Member

@maxorlovsky looks good to me! We can improve it later on, but it's definitely a good start.

Don't worry about the failing test - it is not related to your changes!

@rigor789 rigor789 merged commit 12e5154 into nativescript-vue:master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants