Skip to content

fix: add optional frame property #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2020
Merged

fix: add optional frame property #600

merged 2 commits into from
Jan 23, 2020

Conversation

tarunama
Copy link
Contributor

summary

  • Add optional frame property

ref

related issue #587

rigor789
rigor789 requested changes Jan 10, 2020
View reviewed changes
Copy link
Member

@rigor789 rigor789 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you specify the other accepted types? See

nativescript-vue/platform/nativescript/plugins/navigator-plugin.js

Lines 23 to 30 in 45f71f4

export function getFrameInstance(frame) {
// get the frame that we need to navigate
// this can be a frame id (String)
// a Vue ref to a frame
// a Frame ViewNode
// or a Frame instance
if (isObject(frame) && isDef(frame.$el)) {
frame = frame.$el.nativeView
for all the acceptable values

@tarunama tarunama requested a review from rigor789 January 23, 2020 13:07
@rigor789 rigor789 merged commit d2a5519 into nativescript-vue:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rigor789 rigor789 rigor789 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarunama @rigor789