Skip to content

Commit 04792d5

Browse files
authored
Add timestamps to aggregators and OTLP metrics exporter (open-telemetry#1199)
1 parent 5f2cbfa commit 04792d5

File tree

7 files changed

+183
-186
lines changed

7 files changed

+183
-186
lines changed

exporter/opentelemetry-exporter-otlp/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
## Unreleased
44

5+
- Add timestamps to OTLP exporter
6+
([#1199](https://github.com/open-telemetry/opentelemetry-python/pull/1199))
57
- Update OpenTelemetry protos to v0.5.0
68
([#1143](https://github.com/open-telemetry/opentelemetry-python/pull/1143))
79

exporter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/metrics_exporter/__init__.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,12 @@ def _get_data_points(
8585
data_point_class(
8686
labels=string_key_values,
8787
value=view_data.aggregator.current,
88+
start_time_unix_nano=(
89+
view_data.aggregator.last_checkpoint_timestamp
90+
),
91+
time_unix_nano=(
92+
view_data.aggregator.last_update_timestamp
93+
),
8894
)
8995
)
9096
break

exporter/opentelemetry-exporter-otlp/tests/test_otlp_metric_exporter.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
from collections import OrderedDict
1616
from unittest import TestCase
17+
from unittest.mock import patch
1718

1819
from opentelemetry.exporter.otlp.metrics_exporter import OTLPMetricsExporter
1920
from opentelemetry.proto.collector.metrics.v1.metrics_service_pb2 import (
@@ -59,9 +60,12 @@ def setUp(self):
5960
resource,
6061
)
6162

62-
def test_translate_metrics(self):
63+
@patch("opentelemetry.sdk.metrics.export.aggregate.time_ns")
64+
def test_translate_metrics(self, mock_time_ns):
6365
# pylint: disable=no-member
6466

67+
mock_time_ns.configure_mock(**{"return_value": 1})
68+
6569
self.counter_metric_record.instrument.add(1, OrderedDict([("a", "b")]))
6670

6771
expected = ExportMetricsServiceRequest(
@@ -91,6 +95,7 @@ def test_translate_metrics(self):
9195
)
9296
],
9397
value=1,
98+
time_unix_nano=1,
9499
)
95100
],
96101
aggregation_temporality=(

opentelemetry-sdk/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
## Unreleased
44

5+
- Add timestamps to aggregators
6+
([#1199](https://github.com/open-telemetry/opentelemetry-python/pull/1199))
57
- Add Global Error Handler
68
([#1080](https://github.com/open-telemetry/opentelemetry-python/pull/1080))
79
- Update sampling result names

0 commit comments

Comments
 (0)